Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update R2 CreateBucket to include storage class in request body #5561

Merged
merged 2 commits into from Apr 10, 2024

Conversation

ocsfrank
Copy link
Contributor

@ocsfrank ocsfrank commented Apr 8, 2024

What this PR solves / how to test

Fixes R2-1963. A small fix to update the CreateBucket to include the storage class in the request body. Manually tested creating a bucket with a storage class.

Author has addressed the following

@ocsfrank ocsfrank requested a review from a team as a code owner April 8, 2024 20:46
Copy link

changeset-bot bot commented Apr 8, 2024

🦋 Changeset detected

Latest commit: 1efde45

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 8, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8634430926/npm-package-wrangler-5561

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5561/npm-package-wrangler-5561

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8634430926/npm-package-wrangler-5561 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8634430926/npm-package-create-cloudflare-5561 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8634430926/npm-package-cloudflare-kv-asset-handler-5561
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8634430926/npm-package-miniflare-5561
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8634430926/npm-package-cloudflare-pages-shared-5561
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8634430926/npm-package-cloudflare-vitest-pool-workers-5561

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.48.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240404.0
workerd 1.20240404.0 1.20240404.0
workerd --version 1.20240404.0 2024-04-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@ocsfrank ocsfrank changed the title Update CreateBucket to include storage class in request body Update R2 CreateBucket to include storage class in request body Apr 8, 2024
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick fix to the changeset

.changeset/odd-squids-fly.md Outdated Show resolved Hide resolved
@petebacondarwin petebacondarwin merged commit 59591cd into cloudflare:main Apr 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants