Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[D1] initial wrangler d1 export #5425

Merged
merged 5 commits into from Mar 29, 2024
Merged

[D1] initial wrangler d1 export #5425

merged 5 commits into from Mar 29, 2024

Conversation

rozenmd
Copy link
Contributor

@rozenmd rozenmd commented Mar 28, 2024

LDW CR: CR-851796

Author has addressed the following

@rozenmd rozenmd requested review from a team as code owners March 28, 2024 15:27
Copy link

changeset-bot bot commented Mar 28, 2024

🦋 Changeset detected

Latest commit: fe7114c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 28, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8472051916/npm-package-wrangler-5425

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5425/npm-package-wrangler-5425

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8472051916/npm-package-wrangler-5425 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8472051916/npm-package-create-cloudflare-5425 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8472051916/npm-package-cloudflare-kv-asset-handler-5425
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8472051916/npm-package-miniflare-5425
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8472051916/npm-package-cloudflare-pages-shared-5425
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8472051916/npm-package-cloudflare-vitest-pool-workers-5425

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.39.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240320.0
workerd 1.20240320.1 1.20240320.1
workerd --version 1.20240320.1 2024-03-20

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 72.24%. Comparing base (3e5a932) to head (fe7114c).
Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #5425       +/-   ##
=========================================
+ Coverage      0   72.24%   +72.24%     
=========================================
  Files         0      324      +324     
  Lines         0    16752    +16752     
  Branches      0     4283     +4283     
=========================================
+ Hits          0    12102    +12102     
- Misses        0     4650     +4650     
Files Coverage Δ
packages/wrangler/src/d1/index.ts 88.88% <100.00%> (ø)
packages/wrangler/src/d1/export.ts 28.94% <28.94%> (ø)

... and 322 files with indirect coverage changes

Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I think this should still have tests for argument validation, accepting multiple tables and sending a correctly structured request. I recognise timing is tight here though, and the functionality looks good. Would you be able to create a ticket to track adding testing as a fast-follow?

@mrbbot mrbbot added the ldw-exempt PRs marked with this label can be included in releases during LDW. label Mar 29, 2024
@rozenmd
Copy link
Contributor Author

rozenmd commented Mar 29, 2024

Yep @mrbbot, can do

@mrbbot mrbbot merged commit b7a6d9d into main Mar 29, 2024
20 checks passed
@mrbbot mrbbot deleted the d1-import-export branch March 29, 2024 12:50
@lrapoport-cf
Copy link
Contributor

Approved, but I think this should still have tests for argument validation, accepting multiple tables and sending a correctly structured request. I recognise timing is tight here though, and the functionality looks good. Would you be able to create a ticket to track adding testing as a fast-follow?

for posterity: it appears the fast follow issue is #5442, to be closed by #5444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ldw-exempt PRs marked with this label can be included in releases during LDW.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants