New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[D1] initial wrangler d1 export
#5425
Conversation
🦋 Changeset detectedLatest commit: fe7114c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8472051916/npm-package-wrangler-5425 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5425/npm-package-wrangler-5425 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8472051916/npm-package-wrangler-5425 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8472051916/npm-package-create-cloudflare-5425 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8472051916/npm-package-cloudflare-kv-asset-handler-5425 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8472051916/npm-package-miniflare-5425 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8472051916/npm-package-cloudflare-pages-shared-5425 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8472051916/npm-package-cloudflare-vitest-pool-workers-5425 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5425 +/- ##
=========================================
+ Coverage 0 72.24% +72.24%
=========================================
Files 0 324 +324
Lines 0 16752 +16752
Branches 0 4283 +4283
=========================================
+ Hits 0 12102 +12102
- Misses 0 4650 +4650
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but I think this should still have tests for argument validation, accepting multiple tables and sending a correctly structured request. I recognise timing is tight here though, and the functionality looks good. Would you be able to create a ticket to track adding testing as a fast-follow?
Yep @mrbbot, can do |
for posterity: it appears the fast follow issue is #5442, to be closed by #5444 |
LDW CR: CR-851796
Author has addressed the following
wrangler d1 export
#5425 (comment))