Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wrangler): Queue delivery delay support in wrangler.toml #5413

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

pmiguel
Copy link
Contributor

@pmiguel pmiguel commented Mar 27, 2024

What this PR solves / how to test

Fixes # MQ-565

LDW Exemption under CR-850147

Author has addressed the following

Copy link

changeset-bot bot commented Mar 27, 2024

🦋 Changeset detected

Latest commit: f18999d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 27, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8472921758/npm-package-wrangler-5413

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5413/npm-package-wrangler-5413

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8472921758/npm-package-wrangler-5413 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8472921758/npm-package-create-cloudflare-5413 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8472921758/npm-package-cloudflare-kv-asset-handler-5413
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8472921758/npm-package-miniflare-5413
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8472921758/npm-package-cloudflare-pages-shared-5413
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8472921758/npm-package-cloudflare-vitest-pool-workers-5413

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.39.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240320.0
workerd 1.20240320.1 1.20240320.1
workerd --version 1.20240320.1 2024-03-20

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 72.34%. Comparing base (aa22144) to head (f18999d).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5413      +/-   ##
==========================================
+ Coverage   72.24%   72.34%   +0.10%     
==========================================
  Files         323      325       +2     
  Lines       16713    16817     +104     
  Branches     4275     4307      +32     
==========================================
+ Hits        12074    12166      +92     
- Misses       4639     4651      +12     
Files Coverage Δ
packages/wrangler/src/deploy/deploy.ts 93.39% <100.00%> (+3.03%) ⬆️
...ackages/wrangler/src/queues/cli/commands/create.ts 100.00% <100.00%> (ø)
packages/wrangler/src/queues/client.ts 96.66% <100.00%> (+0.23%) ⬆️
packages/wrangler/src/triggers/deploy.ts 77.19% <100.00%> (ø)
packages/wrangler/src/config/validation.ts 89.85% <60.00%> (-0.17%) ⬇️

... and 8 files with indirect coverage changes

@pmiguel pmiguel force-pushed the pleal/toml-support-queue-delays branch 9 times, most recently from 945705c to f0ec3b3 Compare March 28, 2024 14:55
@pmiguel pmiguel marked this pull request as ready for review March 28, 2024 15:18
@pmiguel pmiguel requested review from a team as code owners March 28, 2024 15:18
@pmiguel pmiguel changed the title feat(wrangler): Queue delivery delay support in wrangler.toml feat: Queue delivery delay support in wrangler.toml Mar 28, 2024
@pmiguel pmiguel force-pushed the pleal/toml-support-queue-delays branch 3 times, most recently from 2bc5f57 to 86bc481 Compare March 28, 2024 18:34
@pmiguel pmiguel changed the title feat: Queue delivery delay support in wrangler.toml feat(wrangler): Queue delivery delay support in wrangler.toml Mar 28, 2024
@RamIdeas RamIdeas force-pushed the pleal/toml-support-queue-delays branch from 86bc481 to c3e9a08 Compare March 28, 2024 19:39
@RamIdeas RamIdeas force-pushed the pleal/toml-support-queue-delays branch from c3e9a08 to f18999d Compare March 28, 2024 19:53
@RamIdeas RamIdeas merged commit 976adec into cloudflare:main Mar 28, 2024
17 checks passed
@lrapoport-cf lrapoport-cf added the ldw-exempt PRs marked with this label can be included in releases during LDW. label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ldw-exempt PRs marked with this label can be included in releases during LDW.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants