fix(wrangler): Improvements to --init-from-dash
#5374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5f47d98 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8559131060/npm-package-wrangler-5374You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5374/npm-package-wrangler-5374Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8559131060/npm-package-wrangler-5374 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8559131060/npm-package-create-cloudflare-5374 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8559131060/npm-package-cloudflare-kv-asset-handler-5374npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8559131060/npm-package-miniflare-5374npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8559131060/npm-package-cloudflare-pages-shared-5374npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8559131060/npm-package-cloudflare-vitest-pool-workers-5374Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5374 +/- ##
==========================================
+ Coverage 72.15% 72.20% +0.04%
==========================================
Files 332 332
Lines 17249 17246 -3
Branches 4408 4405 -3
==========================================
+ Hits 12446 12452 +6
+ Misses 4803 4794 -9
|
- Include user limits in wrangler.toml - Hide usage model from wrangler.toml in all cases
maxwellpeterson
force-pushed
the
init-from-dash
branch
from
2cbedab
to
5f47d98
Compare
penalosa
approved these changes
Apr 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
Fixes WP-868. The
usage_modelconfig field is always ignored by wrangler and should not be set.Author has addressed the following