Allow setting d1 database id in pages dev #3485
Merged
+122
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d36687e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5322823523/npm-package-wrangler-3485You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3485/npm-package-wrangler-3485Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5322823523/npm-package-wrangler-3485 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5322823523/npm-package-cloudflare-pages-shared-3485Note that these links will no longer work once the GitHub Actions artifact expires. |
GregBrimble
force-pushed
the
allow-pages-dev-set-d1-database-id
branch
from
c45d4a3 to
8f36018
Compare
Codecov Report
@@ Coverage Diff @@
## main #3485 +/- ##
==========================================
- Coverage 75.18% 75.08% -0.10%
==========================================
Files 183 183
Lines 11055 11075 +20
Branches 2904 2916 +12
==========================================
+ Hits 8312 8316 +4
- Misses 2743 2759 +16
|
GregBrimble
force-pushed
the
allow-pages-dev-set-d1-database-id
branch
from
8f36018 to
6349a16
Compare
Cherry
reviewed
Jun 17, 2023
GregBrimble
force-pushed
the
allow-pages-dev-set-d1-database-id
branch
2 times, most recently
from
009a2b4 to
2debdc9
Compare
RamIdeas
reviewed
Jun 19, 2023
| @@ -32,6 +32,8 @@ const DURABLE_OBJECTS_BINDING_REGEXP = new RegExp( | |||
| /^(?<binding>[^=]+)=(?<className>[^@\s]+)(@(?<scriptName>.*)$)?$/ | |||
| ); | |||
|
|
|||
| const BINDING_REGEXP = new RegExp(/^(?<binding>[^=]+)(?:=(?<ref>[^\s]+))?$/); | |||
There was a problem hiding this comment.
(nit) Is the new RegExp needed? Seeing as the regex is composed syntactically
jahands
reviewed
Jun 19, 2023
GregBrimble
force-pushed
the
allow-pages-dev-set-d1-database-id
branch
from
828a085 to
db5560f
Compare
Skye-31
reviewed
Jun 19, 2023
GregBrimble
force-pushed
the
allow-pages-dev-set-d1-database-id
branch
from
d1c625a to
bfe1d02
Compare
|
Rebased so fixture tests actually run after #3489 🙃 |
jahands
reviewed
Jun 19, 2023
jahands
approved these changes
Jun 20, 2023
Merged
lrapoport-cf
pushed a commit
that referenced
this pull request
Aug 11, 2023
* Allow setting d1 database id in pages dev * Allow KV and R2 to be referenced to too * Fix state directory in fixture test * Add comments describing the binding regexps * Remove duplicate import * More defensively parse bindings
This was referenced Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test:
Allows setting a D1 database ID when using
wrangler pages devby providing an optional=<ID>suffix to the argument like--d1 BINDING_NAME=database-id.This is useful when a Worker and a Pages project are sharing local dev state (
--persist-to) location.Author has included the following, where applicable:
Reviewer is to perform the following, as applicable: