-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C3 e2e #3483
C3 e2e #3483
Conversation
🦋 Changeset detectedLatest commit: 02f019f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5315194765/npm-package-wrangler-3483 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3483/npm-package-wrangler-3483 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5315194765/npm-package-wrangler-3483 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5315194765/npm-package-cloudflare-pages-shared-3483 Note that these links will no longer work once the GitHub Actions artifact expires. |
Codecov Report
@@ Coverage Diff @@
## main #3483 +/- ##
==========================================
+ Coverage 75.18% 75.23% +0.04%
==========================================
Files 183 183
Lines 11055 11064 +9
Branches 2904 2906 +2
==========================================
+ Hits 8312 8324 +12
+ Misses 2743 2740 -3
|
fb044ef
to
c6f35fb
Compare
@@ -104,7 +104,7 @@ export function stripTimings(stdout: string): string { | |||
export function npmStripTimings(stdout: string): string { | |||
return stdout | |||
.replace( | |||
/added \d+ packages, and audited \d+ packages in \d+s/, | |||
/added \d+ packages, and audited \d+ packages in [\dms]+/, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\d+m?s
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is really slow it can take more than a minute, in which case you get ...and audited 20 pages in 1m
rather than say ...and audited 20 pages in 60s
}); | ||
|
||
it("init project via c3", async () => { | ||
const pathToC3 = path.resolve(__dirname, "../../create-cloudflare"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally this would use the same npm pack
approach as Wrangler, but that can be a followup
Fixes # [insert GH or internal issue number(s)].
What this PR solves / how to test:
Associated docs issue(s)/PR(s):
Author has included the following, where applicable:
Reviewer is to perform the following, as applicable: