Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wrangler] feat: add support for placement in wrangler config #3095

Merged
merged 3 commits into from May 8, 2023

Conversation

zebp
Copy link
Contributor

@zebp zebp commented Apr 25, 2023

Allows a placement object in the wrangler config with a mode of off or smart to configure Smart placement.

What this PR solves / how to test:

Allows users to enable Smart placement via wrangler.

Author has included the following, where applicable:

Reviewer has performed the following, where applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

@zebp zebp requested a review from a team as a code owner April 25, 2023 16:20
@changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2023

🦋 Changeset detected

Latest commit: 97de11d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4885593866/npm-package-wrangler-3095

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3095/npm-package-wrangler-3095

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4885593866/npm-package-wrangler-3095 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4885593866/npm-package-cloudflare-pages-shared-3095

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #3095 (97de11d) into main (8818f55) will increase coverage by 0.48%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3095      +/-   ##
==========================================
+ Coverage   74.39%   74.87%   +0.48%     
==========================================
  Files         168      179      +11     
  Lines       10585    10824     +239     
  Branches     2831     2859      +28     
==========================================
+ Hits         7875     8105     +230     
- Misses       2710     2719       +9     
Impacted Files Coverage Δ
...ler/src/api/pages/create-worker-bundle-contents.ts 100.00% <ø> (ø)
packages/wrangler/src/dev/remote.tsx 7.73% <ø> (ø)
packages/wrangler/src/secret/index.ts 86.46% <ø> (ø)
packages/wrangler/src/worker.ts 100.00% <ø> (ø)
packages/wrangler/src/init.ts 93.56% <50.00%> (-0.26%) ⬇️
packages/wrangler/src/config/validation.ts 90.65% <100.00%> (+0.08%) ⬆️
packages/wrangler/src/create-worker-upload-form.ts 89.18% <100.00%> (+0.09%) ⬆️
packages/wrangler/src/publish/publish.ts 87.50% <100.00%> (+0.06%) ⬆️

... and 17 files with indirect coverage changes

Allows a placement object in the wrangler config with a mode of off or
smart to configure Smart placement.
.changeset/short-bottles-smell.md Outdated Show resolved Hide resolved
packages/wrangler/src/init.ts Outdated Show resolved Hide resolved
packages/wrangler/src/worker.ts Outdated Show resolved Hide resolved
packages/wrangler/src/config/environment.ts Outdated Show resolved Hide resolved
@lrapoport-cf lrapoport-cf merged commit 133c042 into cloudflare:main May 8, 2023
11 checks passed
@zebp zebp deleted the zeb/add-placement branch May 8, 2023 16:57
@github-actions github-actions bot mentioned this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants