Rethrow abort exception on IoContext::run #3699
Merged
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're seeing errors getting reported from actors trying to run promises without an active request. We've determined this is from tasks trying to run after an actor's IO context has been aborted. This change stores the abort exception in the `IoContext` and rethrows it in `IoContext::run`.
tewaro
approved these changes
Mar 11, 2025
|
Can we add a test to not regress in the future? |
Maybe...? It'd have to be incredibly hacky since this is just turning an assertion failure that was only observable as a log message into another log message that isn't reported as an internal error... |
|
I'll continue looking into adding a test for this but I don't think it's worth blocking since this is one of our highest recorded issues. |
kentonv
reviewed
Mar 12, 2025
| @@ -336,6 +336,7 @@ class IoContext final: public kj::Refcounted, private kj::TaskSet::ErrorHandler | |||
|
|
|||
| // Force context abort now. | |||
| void abort(kj::Exception&& e) { | |||
| abortException = kj::cp(e); | |||
There was a problem hiding this comment.
Two issues:
- Probably this should not overwrite the exception if abort() is called twice.
- There is at least one place in the code where we call
abortFulfiller->rejectdirectly rather than calling this abort method. We should probably change it to call this abort().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing errors getting reported from actors trying to run promises without an active request. We've determined this is from tasks trying to run after an actor's IO context has been aborted. This change stores the abort exception in the
IoContextand rethrows it inIoContext::run.