use ada-url's url_pattern implementation #3529
Merged
+482
−1,953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The generated output of |
danlapid
reviewed
Feb 12, 2025
danlapid
reviewed
Feb 12, 2025
danlapid
reviewed
Feb 12, 2025
danlapid
reviewed
Feb 12, 2025
danlapid
reviewed
Feb 12, 2025
danlapid
reviewed
Feb 12, 2025
danlapid
reviewed
Feb 12, 2025
danlapid
reviewed
Feb 12, 2025
anonrig
force-pushed
the
yagiz/replace-urlpattern
branch
3 times, most recently
from
d75b95c to
5764de6
Compare
anonrig
force-pushed
the
yagiz/replace-urlpattern
branch
4 times, most recently
from
449ffb5 to
e2ea03b
Compare
This was referenced Feb 14, 2025
anonrig
force-pushed
the
yagiz/replace-urlpattern
branch
4 times, most recently
from
7b67ff7 to
16322b2
Compare
|
Other than putting this behind a flag like @jasnell recommended, this is ready to review. |
fhanau
reviewed
Feb 18, 2025
fhanau
reviewed
Feb 18, 2025
fhanau
reviewed
Feb 18, 2025
anonrig
force-pushed
the
yagiz/replace-urlpattern
branch
3 times, most recently
from
d0bcac0 to
356a41f
Compare
fhanau
reviewed
Mar 7, 2025
jasnell
reviewed
Mar 7, 2025
jasnell
reviewed
Mar 7, 2025
jasnell
reviewed
Mar 7, 2025
anonrig
force-pushed
the
yagiz/replace-urlpattern
branch
from
356a41f to
d5895c3
Compare
jasnell
approved these changes
Mar 7, 2025
danlapid
reviewed
Mar 7, 2025
anonrig
force-pushed
the
yagiz/replace-urlpattern
branch
4 times, most recently
from
ebd713f to
0c484db
Compare
jasnell
approved these changes
Mar 10, 2025
anonrig
force-pushed
the
yagiz/replace-urlpattern
branch
6 times, most recently
from
42bd946 to
46da31a
Compare
anonrig
force-pushed
the
yagiz/replace-urlpattern
branch
from
46da31a to
e82bd39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we moved URLPattern implementation to Ada and shared it with Node.js, we can now use it as a dependency and get rid of our implementation. This will allow us to have higher compatibility with the web-platform tests and spec, and reduce our codebase by 3800 lines...
Additionally with the help of @npaun, we now run web-platform tests and can get rid of our custom URLPattern tests for better web compatibility and maintenance, since WPT is always changing!
Changes
get hasRegExpGroups(): boolean;fieldTODO