Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ada-url's url_pattern implementation #3529

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Feb 11, 2025

Since we moved URLPattern implementation to Ada and shared it with Node.js, we can now use it as a dependency and get rid of our implementation. This will allow us to have higher compatibility with the web-platform tests and spec, and reduce our codebase by 3800 lines...

Additionally with the help of @npaun, we now run web-platform tests and can get rid of our custom URLPattern tests for better web compatibility and maintenance, since WPT is always changing!

Changes

  • Adds get hasRegExpGroups(): boolean; field

TODO

  • Put it behind an autogate so we can roll this safely.

Sorry, something went wrong.

Copy link

github-actions bot commented Feb 11, 2025

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@anonrig anonrig force-pushed the yagiz/replace-urlpattern branch 3 times, most recently from d75b95c to 5764de6 Compare February 12, 2025 16:22
@anonrig anonrig force-pushed the yagiz/replace-urlpattern branch 4 times, most recently from 449ffb5 to e2ea03b Compare February 13, 2025 23:55
@anonrig anonrig force-pushed the yagiz/replace-urlpattern branch 4 times, most recently from 7b67ff7 to 16322b2 Compare February 18, 2025 20:38
@anonrig
Copy link
Member Author

anonrig commented Feb 18, 2025

Other than putting this behind a flag like @jasnell recommended, this is ready to review.

@anonrig anonrig force-pushed the yagiz/replace-urlpattern branch 3 times, most recently from d0bcac0 to 356a41f Compare March 7, 2025 20:56
@anonrig anonrig requested review from mikea, danlapid and fhanau March 7, 2025 20:59
@anonrig anonrig force-pushed the yagiz/replace-urlpattern branch from 356a41f to d5895c3 Compare March 7, 2025 21:17
@anonrig anonrig force-pushed the yagiz/replace-urlpattern branch 4 times, most recently from ebd713f to 0c484db Compare March 10, 2025 15:25
@anonrig anonrig force-pushed the yagiz/replace-urlpattern branch 6 times, most recently from 42bd946 to 46da31a Compare March 11, 2025 15:27

Verified

This commit was signed with the committer’s verified signature.
dvandersluis Daniel Vandersluis
@anonrig anonrig force-pushed the yagiz/replace-urlpattern branch from 46da31a to e82bd39 Compare March 11, 2025 23:57
@anonrig anonrig merged commit 7581edc into main Mar 12, 2025
24 of 29 checks passed
@anonrig anonrig deleted the yagiz/replace-urlpattern branch March 12, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants