Make SQLite pass through VFS exceptions to the caller. #3373
+308
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentonv
requested review from
npaun and
jclee
and removed request for
Frederik-Baetens
This way, if the VFS throws a JSG error, it can propagate to the application, instead of the application getting a mysterious SQLITE_IOERROR message.
kentonv
force-pushed
the
kenton/sqlite-vfs-error-passthrough
branch
from
3688a4b to
69e076b
Compare
|
(Had originally assigned @Frederik-Baetens to code review because I misremembered who I had recently been discussing this issue with, it was actually @jclee, so I changed it -- but will accept stamps from anyone) |
justin-mp
approved these changes
Jan 21, 2025
jasnell
reviewed
Jan 21, 2025
jasnell
reviewed
Jan 21, 2025
jasnell
reviewed
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, if the VFS throws a JSG error, it can propagate to the application, instead of the application getting a mysterious SQLITE_IOERROR message.