Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add platform-specific release configuration #1900

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Add platform-specific release configuration #1900

merged 1 commit into from
Apr 4, 2024

Conversation

fhanau
Copy link
Collaborator

@fhanau fhanau commented Mar 26, 2024 •
edited

  • Match macOS wd_benchmark link options with wd_binary options
  • Correct spelling of WIN32_LEAN_AND_MEAN
  • /await and /GF are ignored by clang-cl, no need to pass them in the
    Windows build.

@fhanau fhanau force-pushed the felix/bazel-release-cfg branch 6 times, most recently from 5a286fa to 450b564 Compare March 31, 2024 20:06
@fhanau fhanau changed the title [WIP] Add and overhaul platform-specific release and debug configurations Add platform-specific release configuration Mar 31, 2024
@fhanau fhanau marked this pull request as ready for review March 31, 2024 20:10
@fhanau fhanau requested review from a team as code owners March 31, 2024 20:10
@fhanau fhanau requested review from mikea and jp4a50 March 31, 2024 20:10
@fhanau
Add platform-specific release configuration
4cf42ff 
- Match macOS wd_benchmark link options with wd_binary options
- Correct spelling of WIN32_LEAN_AND_MEAN
- /await and /GF are ignored by clang-cl, no need to pass them in the
  Windows build.
@fhanau
Copy link
Collaborator Author

fhanau commented Apr 4, 2024

Thank you for reviewing James!
CC @penalosa @mrbbot @jp4a50 this has nothing that should cause breakage per se, but there are release configuration changes that did not go through CI before. If problems pop up with releases, please shout!

@fhanau fhanau merged commit 3eb728b into main Apr 4, 2024
10 checks passed
@fhanau fhanau deleted the felix/bazel-release-cfg branch April 4, 2024 16:02
@fhanau fhanau mentioned this pull request Apr 4, 2024
Merged
fhanau added a commit that referenced this pull request Apr 7, 2024
@fhanau
Reland PR #1900 "Add platform-specific release configuration"
187f150 
The original PR failed to apply the `release` configuration to
release_unix, leading to a binary size regression, especially on macOS.
This was caused by bazel using fastbuild mode instead of opt mode,
Rust code was not being optimized and on macOS -DDEBUG was defined
through the bazel toolchain defaults.

- Fix a typo and clarify Windows release config comment

Original commit message:
- Match macOS wd_benchmark link options with wd_binary options
- Correct spelling of WIN32_LEAN_AND_MEAN
- /await and /GF are ignored by clang-cl, no need to pass them in the
  Windows build.
fhanau added a commit that referenced this pull request Apr 7, 2024
@fhanau
Reland PR #1900 "Add platform-specific release configuration"
8012bcd 
The original PR failed to apply the `release` configuration to
`release_unix`, leading to a binary size regression, especially on
macOS. This was caused by bazel using fastbuild mode instead of opt
mode, leading to Rust code not being optimized and -DDEBUG being
defined on macOS through the bazel toolchain defaults.

- Fix a typo and clarify Windows release config comment

Original commit message:
- Match macOS wd_benchmark link options with wd_binary options
- Correct spelling of WIN32_LEAN_AND_MEAN
- /await and /GF are ignored by clang-cl, no need to pass them in the
  Windows build.
@fhanau fhanau mentioned this pull request Apr 7, 2024
Merged
fhanau added a commit that referenced this pull request Apr 23, 2024
@fhanau
Reland PR #1900 "Add platform-specific release configuration"
bf6f1ff 
The original PR failed to apply the `release` configuration to
`release_unix`, leading to a binary size regression, especially on
macOS. This was caused by bazel using fastbuild mode instead of opt
mode, leading to Rust code not being optimized and -DDEBUG being
defined on macOS through the bazel toolchain defaults.

- Fix a typo and clarify Windows release config comment

Original commit message:
- Match macOS wd_benchmark link options with wd_binary options
- Correct spelling of WIN32_LEAN_AND_MEAN
- /await and /GF are ignored by clang-cl, no need to pass them in the
  Windows build.
garrettgu10 pushed a commit that referenced this pull request May 13, 2024
@fhanau @garrettgu10
Reland PR #1900 "Add platform-specific release configuration"
cad7c61 
The original PR failed to apply the `release` configuration to
`release_unix`, leading to a binary size regression, especially on
macOS. This was caused by bazel using fastbuild mode instead of opt
mode, leading to Rust code not being optimized and -DDEBUG being
defined on macOS through the bazel toolchain defaults.

- Fix a typo and clarify Windows release config comment

Original commit message:
- Match macOS wd_benchmark link options with wd_binary options
- Correct spelling of WIN32_LEAN_AND_MEAN
- /await and /GF are ignored by clang-cl, no need to pass them in the
  Windows build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@mikea mikea Awaiting requested review from mikea mikea is a code owner automatically assigned from cloudflare/workers-runtime-1

@jp4a50 jp4a50 Awaiting requested review from jp4a50 jp4a50 is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fhanau @jasnell