Implement URLSearchParams size getter

In preparation for whatwg/url#734 (this shouldn't land until that spec change lands)
cloudflare · Jan 22, 2023 · 90b39f2 · 90b39f2
1 parent fe84260
commit 90b39f2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/workerd/api/url-standard.h b/src/workerd/api/url-standard.h
@@ -126,7 +126,10 @@ class URLSearchParams: public jsg::Object {
 
   jsg::UsvString toString();
 
+  inline uint getSize() { return list.size(); }
+
   JSG_RESOURCE_TYPE(URLSearchParams) {
+    JSG_READONLY_PROTOTYPE_PROPERTY(size, getSize);
     JSG_METHOD(append);
     JSG_METHOD_NAMED(delete, delete_);
     JSG_METHOD(get);

diff --git a/src/workerd/api/url.h b/src/workerd/api/url.h
@@ -174,7 +174,10 @@ class URLSearchParams: public jsg::Object {
 
   kj::String toString();
 
+  inline uint getSize() { return url->query.size(); }
+
   JSG_RESOURCE_TYPE(URLSearchParams, CompatibilityFlags::Reader flags) {
+    JSG_READONLY_PROTOTYPE_PROPERTY(size, getSize);
     JSG_METHOD(append);
     JSG_METHOD_NAMED(delete, delete_);
     JSG_METHOD(get);