Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct name when running dns create-or-update #1944

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: use correct name when running dns create-or-update #1944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1065948
fix: use correct name when running dns create-or-update
OhMyMndy May 5, 2024
cc931c7
Release note
OhMyMndy May 20, 2024
37b1bb6
Merge branch 'master' into create-or-update-fix
OhMyMndy May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/1944.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
cli: fix for DNS create-or-update
```
2 changes: 1 addition & 1 deletion cmd/flarectl/dns.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func dnsCreateOrUpdate(c *cli.Context) error {
return err
}

records, _, err := api.ListDNSRecords(context.Background(), cloudflare.ZoneIdentifier(zoneID), cloudflare.ListDNSRecordsParams{Name: name + "." + zone})
records, _, err := api.ListDNSRecords(context.Background(), cloudflare.ZoneIdentifier(zoneID), cloudflare.ListDNSRecordsParams{Name: name})
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On line 117, the record itself is create with just Name: name, not zone appended to it

if err != nil {
fmt.Fprintln(os.Stderr, "Error fetching DNS records: ", err)
return err
Expand Down