feat: update teams antivirus settings to configure notification

cloudflare · Feb 8, 2024 · f119e22 · f119e22
1 parent cca23db
commit f119e22
Show file tree

Hide file tree

Showing 3 changed files with 57 additions and 41 deletions.
diff --git a/.changelog/1499.txt b/.changelog/1499.txt
@@ -0,0 +1,3 @@
+```release-note:enhancement
+teams_rules: `AntiVirus` settings includes notification settings
+```
diff --git a/teams_accounts.go b/teams_accounts.go
@@ -54,9 +54,10 @@ type BrowserIsolation struct {
 }
 
 type TeamsAntivirus struct {
-	EnabledDownloadPhase bool `json:"enabled_download_phase"`
-	EnabledUploadPhase   bool `json:"enabled_upload_phase"`
-	FailClosed           bool `json:"fail_closed"`
+	EnabledDownloadPhase bool                       `json:"enabled_download_phase"`
+	EnabledUploadPhase   bool                       `json:"enabled_upload_phase"`
+	FailClosed           bool                       `json:"fail_closed"`
+	NotificationSettings *TeamsNotificationSettings `json:"notification_settings"`
 }
 
 type TeamsFIPS struct {

diff --git a/teams_accounts_test.go b/teams_accounts_test.go
@@ -53,44 +53,49 @@ func TestTeamsAccountConfiguration(t *testing.T) {
 			"messages": [],
 			"result": {
 				"settings": {
-					"antivirus": {
-						"enabled_download_phase": true
-					},
-					"tls_decrypt": {
-						"enabled": true
-					},
-					"protocol_detection": {
-						"enabled": true
-					},
-					"fips": {
-						"tls": true
-					},
-					"activity_log": {
-						"enabled": true
-					},
-					"block_page": {
-						"enabled": true,
-						"name": "Cloudflare",
-						"footer_text": "--footer--",
-						"header_text": "--header--",
-						"mailto_address": "admin@example.com",
-						"mailto_subject": "Blocked User Inquiry",
-						"logo_path": "https://logos.com/a.png",
-						"background_color": "#ff0000",
-						"suppress_footer": true
-					},
-					"browser_isolation": {
-						"url_browser_isolation_enabled": true,
-						"non_identity_enabled": true
-          				},
-					"body_scanning": {
-						"inspection_mode": "deep"
-					},
-					"extended_email_matching": {
-						"enabled": true
+				"antivirus": {
+					"enabled_download_phase": true,
+					"notification_settings": {
+					   "enabled":true,
+					   "msg":"msg",
+					   "support_url":"https://hi.com"
 					}
-				}
-			}
+				 },
+				 "tls_decrypt": {
+					"enabled":true
+				 },
+				 "protocol_detection": {
+					"enabled":true
+				 },
+				 "fips": {
+					"tls":true
+				 },
+				 "activity_log": {
+					"enabled":true
+				 },
+				 "block_page": {
+					"enabled":true,
+					"name":"Cloudflare",
+					"footer_text":"--footer--",
+					"header_text":"--header--",
+					"mailto_address":"admin@example.com",
+					"mailto_subject":"Blocked User Inquiry",
+					"logo_path":"https://logos.com/a.png",
+					"background_color":"#ff0000",
+					"suppress_footer":true
+				 },
+				 "browser_isolation": {
+				 	"url_browser_isolation_enabled":true,
+				 	"non_identity_enabled":true
+				 },
+				 "body_scanning": {
+					"inspection_mode":"deep"
+				 },
+				 "extended_email_matching": {
+					"enabled":true
+				 }
+			  }
+		   }
 		}
 		`)
 	}
@@ -101,7 +106,14 @@ func TestTeamsAccountConfiguration(t *testing.T) {
 
 	if assert.NoError(t, err) {
 		assert.Equal(t, actual.Settings, TeamsAccountSettings{
-			Antivirus:         &TeamsAntivirus{EnabledDownloadPhase: true},
+			Antivirus: &TeamsAntivirus{
+				EnabledDownloadPhase: true,
+				NotificationSettings: &TeamsNotificationSettings{
+					Enabled:    &trueValue,
+					Message:    "msg",
+					SupportURL: "https://hi.com",
+				},
+			},
 			ActivityLog:       &TeamsActivityLog{Enabled: true},
 			TLSDecrypt:        &TeamsTLSDecrypt{Enabled: true},
 			ProtocolDetection: &TeamsProtocolDetection{Enabled: true},