Skip to content

Commit

Permalink
Merge pull request #1832 from rowantahseen/config-rules-fonts
Browse files Browse the repository at this point in the history
Add Fonts and Disable Rum to Configuration Rules
  • Loading branch information
jacobbednarz committed May 8, 2024
2 parents 4788db7 + 09bc19e commit afb0b0f
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .changelog/1832.txt
@@ -0,0 +1,3 @@
```release-note:enhancement
ruleset: add support for action parameters `fonts` and `disable_rum`
```
2 changes: 2 additions & 0 deletions rulesets.go
Expand Up @@ -246,7 +246,9 @@ type RulesetRuleActionParameters struct {
DisableApps *bool `json:"disable_apps,omitempty"`
DisableZaraz *bool `json:"disable_zaraz,omitempty"`
DisableRailgun *bool `json:"disable_railgun,omitempty"`
DisableRUM *bool `json:"disable_rum,omitempty"`
EmailObfuscation *bool `json:"email_obfuscation,omitempty"`
Fonts *bool `json:"fonts,omitempty"`
Mirage *bool `json:"mirage,omitempty"`
OpportunisticEncryption *bool `json:"opportunistic_encryption,omitempty"`
Polish *Polish `json:"polish,omitempty"`
Expand Down
6 changes: 5 additions & 1 deletion rulesets_test.go
Expand Up @@ -403,7 +403,9 @@ func TestGetRuleset_SetConfig(t *testing.T) {
"server_side_excludes":true,
"ssl":"off",
"sxg":true,
"hotlink_protection":true
"hotlink_protection":true,
"fonts":true,
"disable_rum":true
},
"description": "Set all available config rules in one rule",
"last_updated": "2020-12-18T09:28:09.655749Z",
Expand Down Expand Up @@ -440,7 +442,9 @@ func TestGetRuleset_SetConfig(t *testing.T) {
DisableApps: BoolPtr(true),
DisableZaraz: BoolPtr(true),
DisableRailgun: BoolPtr(true),
DisableRUM: BoolPtr(true),
EmailObfuscation: BoolPtr(true),
Fonts: BoolPtr(true),
Mirage: BoolPtr(true),
OpportunisticEncryption: BoolPtr(true),
Polish: PolishOff.IntoRef(),
Expand Down

0 comments on commit afb0b0f

Please sign in to comment.