Skip to content

Commit

Permalink
s/List/Get
Browse files Browse the repository at this point in the history
  • Loading branch information
jacobbednarz committed Mar 7, 2024
1 parent adb2f04 commit 46a79a1
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
10 changes: 5 additions & 5 deletions access_mutual_tls_certificates.go
Expand Up @@ -64,7 +64,7 @@ type AccessMutualTLSHostnameSettings struct {
Hostname string `json:"hostname,omitempty"`
}

type ListAccessMutualTLSHostnameSettingsResponse struct {
type GetAccessMutualTLSHostnameSettingsResponse struct {
Response
Result []AccessMutualTLSHostnameSettings `json:"result"`
}
Expand Down Expand Up @@ -228,11 +228,11 @@ func (api *API) DeleteAccessMutualTLSCertificate(ctx context.Context, rc *Resour
return nil
}

// ListAccessMutualTLSHostnameSettings returns all Access mTLS hostname settings.
// GetAccessMutualTLSHostnameSettings returns all Access mTLS hostname settings.
//
// Account API Reference: https://developers.cloudflare.com/api/operations/access-mtls-authentication-update-an-mtls-certificate-settings
// Zone API Reference: https://developers.cloudflare.com/api/operations/zone-level-access-mtls-authentication-list-mtls-certificates-hostname-settings
func (api *API) ListAccessMutualTLSHostnameSettings(ctx context.Context, rc *ResourceContainer) ([]AccessMutualTLSHostnameSettings, error) {
func (api *API) GetAccessMutualTLSHostnameSettings(ctx context.Context, rc *ResourceContainer) ([]AccessMutualTLSHostnameSettings, error) {
uri := fmt.Sprintf(
"/%s/%s/access/certificates/settings",
rc.Level,
Expand All @@ -244,7 +244,7 @@ func (api *API) ListAccessMutualTLSHostnameSettings(ctx context.Context, rc *Res
return []AccessMutualTLSHostnameSettings{}, fmt.Errorf("%s: %w", errMakeRequestError, err)
}

var accessMutualTLSHostnameSettingsResponse ListAccessMutualTLSHostnameSettingsResponse
var accessMutualTLSHostnameSettingsResponse GetAccessMutualTLSHostnameSettingsResponse
err = json.Unmarshal(res, &accessMutualTLSHostnameSettingsResponse)
if err != nil {
return []AccessMutualTLSHostnameSettings{}, fmt.Errorf("%s: %w", errUnmarshalError, err)
Expand All @@ -269,7 +269,7 @@ func (api *API) UpdateAccessMutualTLSHostnameSettings(ctx context.Context, rc *R
return []AccessMutualTLSHostnameSettings{}, fmt.Errorf("%s: %w", errMakeRequestError, err)
}

var accessMutualTLSHostnameSettingsResponse ListAccessMutualTLSHostnameSettingsResponse
var accessMutualTLSHostnameSettingsResponse GetAccessMutualTLSHostnameSettingsResponse
err = json.Unmarshal(res, &accessMutualTLSHostnameSettingsResponse)
if err != nil {
return []AccessMutualTLSHostnameSettings{}, fmt.Errorf("%s: %w", errUnmarshalError, err)
Expand Down
8 changes: 4 additions & 4 deletions access_mutual_tls_certificates_test.go
Expand Up @@ -53,15 +53,15 @@ func TestAccessMutualTLSCertificates(t *testing.T) {

mux.HandleFunc("/accounts/"+testAccountID+"/access/certificates", handler)

actual, _, err := client.ListAccessMutualTLSCertificates(context.Background(), testAccountRC, ListAccessMutualTLSCertificatesParams{})
actual, _, err := client.GetAccessMutualTLSCertificates(context.Background(), testAccountRC, GetAccessMutualTLSCertificatesParams{})

Check failure on line 56 in access_mutual_tls_certificates_test.go

View workflow job for this annotation

GitHub Actions / test (1.20)

client.GetAccessMutualTLSCertificates undefined (type *API has no field or method GetAccessMutualTLSCertificates)

Check failure on line 56 in access_mutual_tls_certificates_test.go

View workflow job for this annotation

GitHub Actions / test (1.20)

undefined: GetAccessMutualTLSCertificatesParams

Check failure on line 56 in access_mutual_tls_certificates_test.go

View workflow job for this annotation

GitHub Actions / test (1.21)

client.GetAccessMutualTLSCertificates undefined (type *API has no field or method GetAccessMutualTLSCertificates)

Check failure on line 56 in access_mutual_tls_certificates_test.go

View workflow job for this annotation

GitHub Actions / test (1.21)

undefined: GetAccessMutualTLSCertificatesParams

Check failure on line 56 in access_mutual_tls_certificates_test.go

View workflow job for this annotation

GitHub Actions / test (1.22)

client.GetAccessMutualTLSCertificates undefined (type *API has no field or method GetAccessMutualTLSCertificates)

Check failure on line 56 in access_mutual_tls_certificates_test.go

View workflow job for this annotation

GitHub Actions / test (1.22)

undefined: GetAccessMutualTLSCertificatesParams

if assert.NoError(t, err) {
assert.Equal(t, want, actual)
}

mux.HandleFunc("/zones/"+testZoneID+"/access/certificates", handler)

actual, _, err = client.ListAccessMutualTLSCertificates(context.Background(), testZoneRC, ListAccessMutualTLSCertificatesParams{})
actual, _, err = client.GetAccessMutualTLSCertificates(context.Background(), testZoneRC, GetAccessMutualTLSCertificatesParams{})

Check failure on line 64 in access_mutual_tls_certificates_test.go

View workflow job for this annotation

GitHub Actions / test (1.20)

client.GetAccessMutualTLSCertificates undefined (type *API has no field or method GetAccessMutualTLSCertificates)

Check failure on line 64 in access_mutual_tls_certificates_test.go

View workflow job for this annotation

GitHub Actions / test (1.20)

undefined: GetAccessMutualTLSCertificatesParams

Check failure on line 64 in access_mutual_tls_certificates_test.go

View workflow job for this annotation

GitHub Actions / test (1.21)

client.GetAccessMutualTLSCertificates undefined (type *API has no field or method GetAccessMutualTLSCertificates)

Check failure on line 64 in access_mutual_tls_certificates_test.go

View workflow job for this annotation

GitHub Actions / test (1.21)

undefined: GetAccessMutualTLSCertificatesParams

Check failure on line 64 in access_mutual_tls_certificates_test.go

View workflow job for this annotation

GitHub Actions / test (1.22)

client.GetAccessMutualTLSCertificates undefined (type *API has no field or method GetAccessMutualTLSCertificates)

Check failure on line 64 in access_mutual_tls_certificates_test.go

View workflow job for this annotation

GitHub Actions / test (1.22)

undefined: GetAccessMutualTLSCertificatesParams

if assert.NoError(t, err) {
assert.Equal(t, want, actual)
Expand Down Expand Up @@ -277,7 +277,7 @@ func TestDeleteAccessMutualTLSCertificate(t *testing.T) {
assert.NoError(t, err)
}

func TestListAccessMutualTLSHostnameSettings(t *testing.T) {
func TestGetAccessMutualTLSHostnameSettings(t *testing.T) {
setup()
defer teardown()

Expand Down Expand Up @@ -318,7 +318,7 @@ func TestListAccessMutualTLSHostnameSettings(t *testing.T) {

mux.HandleFunc("/accounts/"+testAccountID+"/access/certificates/settings", handler)

actual, err := client.ListAccessMutualTLSHostnameSettings(context.Background(), testAccountRC)
actual, err := client.GetAccessMutualTLSHostnameSettings(context.Background(), testAccountRC)

if assert.NoError(t, err) {
assert.Equal(t, want, actual)
Expand Down

0 comments on commit 46a79a1

Please sign in to comment.