Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly installs Go with version before CodeQL analysis. #481

Merged
merged 1 commit into from Mar 9, 2024
Merged

Explicitly installs Go with version before CodeQL analysis. #481

merged 1 commit into from Mar 9, 2024

Conversation

armfazh
Copy link
Contributor

@armfazh armfazh commented Feb 17, 2024

Report from CodeQL

Newer Go version needed
[View workflow run](https://github.com/cloudflare/circl/actions/runs/7938355244)
Version v1.20.14 of Go is installed, but this is lower than v1.21 required by your project's go.mod. [Install a newer version of Go before analyzing your project](https://github.com/actions/setup-go#basic).

@armfazh armfazh added the maintenance Related to issues on the repository label Feb 17, 2024
@armfazh armfazh self-assigned this Feb 17, 2024
thibmeu
thibmeu approved these changes Mar 9, 2024
View reviewed changes
Copy link
Contributor

@thibmeu thibmeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a good change indeed

@armfazh armfazh merged commit dc430ec into cloudflare:main Mar 9, 2024
10 checks passed
@armfazh armfazh deleted the fixCodeQL branch March 9, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibmeu thibmeu thibmeu approved these changes

@bwesterb bwesterb Awaiting requested review from bwesterb

Assignees

@armfazh armfazh

Labels
maintenance Related to issues on the repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@armfazh @thibmeu