Reduce x/crypto and x/sys versions to match Go 1.21 #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CIRCL does not necessarily depend on newer x/crypto and x/sys versions.
Lower the version requirements to match Go 1.21.7, this avoids the need
to upgrade stdlib dependencies when integrating circl.
For reference, we drop these `golang.org/x/crypto` commits:
$ git -C ../golang-crypto log --oneline 2e82bdd1719d..v0.17.0 $(go list -deps ./... | grep golang.org/x/crypto/ | sed 's,golang.org/x/crypto/,./,')
$ git -C ../golang-crypto log --oneline 2e82bdd1719d..v0.17.0 ./blake2b ./blake2s ./hkdf ./internal/alias ./chacha20 ./internal/poly1305 ./chacha20poly1305 ./cryptobyte/asn1 ./cryptobyte ./sha3
b8ffc16 blake2b: drop Go 1.6, Go 1.8 compatibility
bda2f3f argon2: avoid clobbering BP
a2edfb5 cryptobyte: fix ReadOptionalASN1Boolean
df0bc9e chacha20poly1305: guard PSHUFB usage with GOAMD64_v2
74c2ba9 crypto/hkdf: remove useless call to Reset
8779cbd all: update go directive to 1.18
ec07f4e chacha20: drop Go 1.10 compatibility for arm64
3f0842a sha3: have ShakeHash extend hash.Hash
e90f1e1 cryptobyte: add uint48 methods
No commits are dropped for `golang.org/x/sys/cpu`.
bwesterb
reviewed
Feb 7, 2024
bwesterb
reviewed
Feb 7, 2024
Lekensteyn
force-pushed
the
pwu/base-go1.21.7
branch
from
744f446
to
52ef15b
Compare
bwesterb
approved these changes
Feb 7, 2024
|
I am puzzled why I am seeing golangci-lint errors in CI. I can reproduce part of it locally: But it goes away as soon as I |
Lekensteyn
force-pushed
the
pwu/base-go1.21.7
branch
from
52ef15b
to
2535e92
Compare
|
I dropped the GitHub actions update change. If that fixes the build failure, I will update this PR title/description. And then open a new PR to try to update GitHub Actions and address golangci-lint issues. |
|
I can update golanci-lint version later, as I have already started working on this locally. |
armfazh
approved these changes
Feb 8, 2024
Lekensteyn
changed the title
|
I now understand why golangci-lint showed such weird errors. The golangci-lint v1.51.2 binary was built with Go 1.20.1 while the golangci-lint v1.56.0 binary was properly built with Go 1.22.0. So in order to be able to update to Go 1.22, a golangci-lint update is needed. That does not seem to be too complicated, so I can make extra changes to the GitHub Actions update. Changes are here: #477 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce x/crypto and x/sys versions to match Go 1.21
CIRCL does not necessarily depend on newer x/crypto and x/sys versions.
Lower the version requirements to match Go 1.21.7, this avoids the need
to upgrade stdlib dependencies when integrating circl.
For reference, we drop these
golang.org/x/cryptocommits:No commits are dropped for
golang.org/x/sys/cpu.I tried bumping various other Golang versions in the GitHub Actions checks, but it failed. I'll open a new PR for those changes. Among the failures from bumping golangci-lint from v1.51.2 to v1.56.0:
golangci-lint v1.56.0 run output