Set CIRCL version for generated assembler code. #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwesterb
approved these changes
May 30, 2023
Lekensteyn
approved these changes
May 30, 2023
There was a problem hiding this comment.
LGTM.
The go.mod and go.sum changes are for /asm which are not imported directly in the main circl module, so it won't affect the minimum x/sys versions in vendored copies.
Also note that the "security advisories" are false positives since the asm code generation code is not calling the random number generator code paths that are affected.
jooola
pushed a commit
to hetznercloud/terraform-provider-hcloud
that referenced
this pull request
Jan 9, 2024
…834) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/cloudflare/circl](https://togithub.com/cloudflare/circl) | `v1.3.3` -> `v1.3.7` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | ### GitHub Vulnerability Alerts #### [GHSA-9763-4f94-gfch](https://togithub.com/cloudflare/circl/security/advisories/GHSA-9763-4f94-gfch) ### Impact On some platforms, when an attacker can time decapsulation of Kyber on forged cipher texts, they could possibly learn (parts of) the secret key. Does not apply to ephemeral usage, such as when used in the regular way in TLS. ### Patches Patched in 1.3.7. ### References - [kyberslash.cr.yp.to](https://kyberslash.cr.yp.to/) --- ### Release Notes <details> <summary>cloudflare/circl (github.com/cloudflare/circl)</summary> ### [`v1.3.7`](https://togithub.com/cloudflare/circl/releases/tag/v1.3.7): CIRCL v1.3.7 [Compare Source](https://togithub.com/cloudflare/circl/compare/v1.3.6...v1.3.7) #### CIRCL v1.3.7 ##### What's Changed - build(deps): bump golang.org/x/crypto from 0.3.1-0.20221117191849-2c476679df9a to 0.17.0 by [@​dependabot](https://togithub.com/dependabot) in [cloudflare/circl#467 - kyber: remove division by q in ciphertext compression by [@​bwesterb](https://togithub.com/bwesterb) in [cloudflare/circl#468 - Releasing CIRCL v1.3.7 by [@​armfazh](https://togithub.com/armfazh) in [cloudflare/circl#469 ##### New Contributors - [@​dependabot](https://togithub.com/dependabot) made their first contribution in [cloudflare/circl#467 **Full Changelog**: cloudflare/circl@v1.3.6...v1.3.7 ### [`v1.3.6`](https://togithub.com/cloudflare/circl/releases/tag/v1.3.6): CIRCL v1.3.6 [Compare Source](https://togithub.com/cloudflare/circl/compare/v1.3.5...v1.3.6) #### CIRCL v1.3.6 ##### What's Changed - internal: add TurboShake{128,256} by [@​bwesterb](https://togithub.com/bwesterb) in [cloudflare/circl#430 - Kangaroo12 draft -10 by [@​bwesterb](https://togithub.com/bwesterb) in [cloudflare/circl#431 - Add K12 as XOF by [@​bwesterb](https://togithub.com/bwesterb) in [cloudflare/circl#437 - xof/k12: Fix a typo in the package documentation by [@​cjpatton](https://togithub.com/cjpatton) in [cloudflare/circl#438 - Set CIRCL version for generated assembler code. by [@​armfazh](https://togithub.com/armfazh) in [cloudflare/circl#440 - Add tkn20 benchmarks by [@​tanyav2](https://togithub.com/tanyav2) in [cloudflare/circl#442 - Add partially blind RSA implementation by [@​chris-wood](https://togithub.com/chris-wood) in [cloudflare/circl#445 - Update doc.go by [@​nadimkobeissi](https://togithub.com/nadimkobeissi) in [cloudflare/circl#447 - tss/rsa: key generation for threshold RSA (safe primes) by [@​armfazh](https://togithub.com/armfazh) in [cloudflare/circl#450 - Bumping Go version for CI jobs. by [@​armfazh](https://togithub.com/armfazh) in [cloudflare/circl#457 - Spelling by [@​jsoref](https://togithub.com/jsoref) in [cloudflare/circl#456 - blindrsa: updating blindrsa to be compliant with RFC9474 by [@​armfazh](https://togithub.com/armfazh) in [cloudflare/circl#464 - Releasing CIRCL v1.3.6 by [@​armfazh](https://togithub.com/armfazh) in [cloudflare/circl#465 ##### New Contributors - [@​nadimkobeissi](https://togithub.com/nadimkobeissi) made their first contribution in [cloudflare/circl#447 - [@​jsoref](https://togithub.com/jsoref) made their first contribution in [cloudflare/circl#456 **Full Changelog**: cloudflare/circl@v1.3.3...v1.3.6 ### [`v1.3.5`](https://togithub.com/cloudflare/circl/compare/v1.3.4...v1.3.5) [Compare Source](https://togithub.com/cloudflare/circl/compare/v1.3.4...v1.3.5) ### [`v1.3.4`](https://togithub.com/cloudflare/circl/compare/v1.3.3...v1.3.4) [Compare Source](https://togithub.com/cloudflare/circl/compare/v1.3.3...v1.3.4) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/hetznercloud/terraform-provider-hcloud). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps to remove our own security advisory.
@Lekensteyn could you please verify if the version of stdlib dependencies are ok, regarding our integration with cfgo.