Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ascon-80pq to cipher\ascon #404

Merged
merged 1 commit into from Feb 20, 2023
Merged

Add Ascon-80pq to cipher\ascon #404

merged 1 commit into from Feb 20, 2023

Conversation

dhcgn
Copy link
Contributor

@dhcgn dhcgn commented Feb 19, 2023

Since this repo has a focus on PQ, I would like to suggest including the PQ optimized variant of Ascon.

Ascon-80pq has an increased key-size to provide more resistance against a quantum
adversary using Grover’s algorithm for key search. Since Ascon-128 and Ascon-
80pq share the same building blocks and same parameters except the size of the key,
we claim the same security for Ascon-80pq against classical attacks as for Ascon-128.
[...]
The only difference between Ascon-80pq and Ascon-128 is the increased length of
the key. This increased key length provides additional protection against exhaustive
key search in the case the availability of quantum computers becomes evident. Since
the other tunable security parameters (the number of rounds of the permutations)
have not been increased, the security claim for Ascon-80pq against classical attacks
stays the same as for Ascon-128.

Source: https://ascon.iaik.tugraz.at/files/asconv12-nist.pdf

@armfazh armfazh self-assigned this Feb 20, 2023
@armfazh armfazh self-requested a review February 20, 2023 19:24
Copy link
Contributor

@armfazh armfazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks @dhcgn

@armfazh
Copy link
Contributor

armfazh commented Feb 20, 2023

Could you please squash the commits, so we can merge it.

@dhcgn dhcgn marked this pull request as ready for review February 20, 2023 19:41
@armfazh
Copy link
Contributor

armfazh commented Feb 20, 2023

I just generated the test vectors file for Ascon80pq using pyascon.

https://github.com/meichlseder/pyascon

The ciphertext do not matches with the test vector in Go. Could you please confirm it.

Copy link
Contributor

@armfazh armfazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hold until having matching test vectors

Copy link
Contributor

@armfazh armfazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, my local branch of pyascon was outdated. Pyascon impl had a bug (see meichlseder/pyascon#2). Confirming test vectors are ok.

@armfazh armfazh merged commit 801c327 into cloudflare:main Feb 20, 2023
@dhcgn dhcgn deleted the ascon-80pq branch February 20, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants