Create the automatic key when specified with -i

[cmbrose]

Fixes: #9817

Fixes the flow with gh cs ssh --config where the automatic key is specified, but the subsequent ssh command does not actually generate the key.

[liskin]

Hm, I just tried this and I'm still getting the same error :-(

$ /tmp/cli/bin/gh cs ssh -c alarming-crypt-vq9p499742wgxq --stdio -- -i codespaces.auto
error getting ssh server details: failed to read public key file: open codespaces.auto.pub: no such file or directory

(But I'll try and dig deeper and figure out what's happening. Haven't done much Go before so it'll be fun.)

[liskin]

Right, it doesn't work because the private key argument to -i, as well as the output of automaticPrivateKeyPath(sshContext) are relative. If I cd ~/.ssh first, then it all works, but that's obviously not how it's meant to be used. I think we should probably use

cli/pkg/ssh/ssh_keys.go

Line 82 in b4c221d

func (c *Context) SshDir() (string, error) {

at a few more places rather than just

cli/pkg/ssh/ssh_keys.go

Lines 16 to 17 in b4c221d

	type Context struct {
	ConfigDir string

which is normally empty.

[cmbrose]

Nice catch @liskin - that was a bug from some refactoring I did for the tests actually. Fixed in 940560a

[liskin]

Nice catch @liskin - that was a bug from some refactoring I did for the tests actually. Fixed in 940560a

Yep, that fixes it. (But the CI seems not to like it :-))

[dmgardiner25]

Thanks for fixing this up!

[andyfeller]

Everything looks good! Made a minor change around newly added code comment but only thing.

[andyfeller]

Minor readability improvement

Suggested change

	// specified values. It should only be used to testing to inject test-specific setup.
	// specified values. It should only be used to inject test-specific setup.

[andyfeller]

I made and pushed this up rather than block merging changes waiting for someone else to do it. 🙇

[andyfeller]

Not something that has to be fixed, but I wonder if code like this could be simplified as:

Suggested change

	sshDir, err := opts.sshContext.SshDir()
	if err != nil {
	t.Errorf("Could not load ssh config dir: %v", err)
	}
	sshDir, err := opts.sshContext.SshDir()
	require.NoErrorf(t, err, "Could not load ssh config dir")

[andyfeller]

Suggested change

	sshDir, err := opts.sshContext.SshDir()
	if err != nil {
	t.Errorf("Could not load ssh config dir: %v", err)
	}
	sshDir, err := opts.sshContext.SshDir()
	require.NoErrorf(t, err, "Could not load ssh config dir")