Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clerk-js,shared,nextjs): Support __clerk_db_jwt and __dev_session query params #2428

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

dimkl
Copy link
Member

@dimkl dimkl commented Dec 20, 2023

Description

Support reading from __clerk_db_jwt and __dev_session query param the dev browser jwt. This is a preparation step to support Account Portal with v5 version.

2 more PRs will follow:

  • in AP to bump to this @clerk/nextjs version
  • in ClerkJS to replace __dev_session with __clerk_db_jwt

REVIEW IT PER COMMIT

SDK-746

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@dimkl dimkl self-assigned this Dec 20, 2023
@dimkl dimkl requested a review from a team as a code owner December 20, 2023 23:33
Copy link

changeset-bot bot commented Dec 20, 2023

🦋 Changeset detected

Latest commit: 6575d30

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@clerk/clerk-js Minor
@clerk/nextjs Minor
@clerk/shared Minor
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/backend Patch
@clerk/fastify Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
gatsby-plugin-clerk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dimkl dimkl changed the title chore(clerk-js,shared,nextjs): Move setDevBrowserJWTInURL to shared chore(clerk-js,shared,nextjs): Support __clerk_db_jwt and __dev_session query params Dec 20, 2023
@dimkl dimkl force-pushed the fix-clerk-db-jwt-qs branch 2 times, most recently from c2e1972 to a5f4d8e Compare December 21, 2023 00:23
@dimkl dimkl added this pull request to the merge queue Dec 21, 2023
@dimkl dimkl removed this pull request from the merge queue due to a manual request Dec 21, 2023
@dimkl dimkl enabled auto-merge December 21, 2023 09:04
@dimkl dimkl added this pull request to the merge queue Dec 21, 2023
Merged via the queue into release/v4 with commit df40705 Dec 21, 2023
6 checks passed
@dimkl dimkl deleted the fix-clerk-db-jwt-qs branch December 21, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants