Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs): Accept redirectUrl as option for auth().protect() #2329 #2333

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

panteliselef
Copy link
Member

@panteliselef panteliselef commented Dec 13, 2023

Description

Backport of #2329

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

Sorry, something went wrong.

@panteliselef panteliselef self-assigned this Dec 13, 2023
@panteliselef panteliselef requested a review from a team as a code owner December 13, 2023 09:37
@panteliselef panteliselef requested review from nikosdouvlis and removed request for a team December 13, 2023 09:37
Copy link

changeset-bot bot commented Dec 13, 2023

🦋 Changeset detected

Latest commit: 3d9144d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@dimkl dimkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 Please add a description before merging.

@panteliselef panteliselef force-pushed the elef/backport-core-1219 branch from d95a4c4 to e7ed295 Compare December 13, 2023 09:52
@panteliselef
Copy link
Member Author

!snapshot

@panteliselef
Copy link
Member Author

The same PR for v5 fails for the E2E tests, need to investigate more before merging this one.
#2329

@panteliselef panteliselef changed the title feat(nextjs): Accept redirectUrl as option for auth().protect() feat(nextjs): Accept redirectUrl as option for auth().protect() #2329 Dec 13, 2023
@panteliselef panteliselef added this pull request to the merge queue Dec 13, 2023
@panteliselef panteliselef removed this pull request from the merge queue due to a manual request Dec 13, 2023
@panteliselef
Copy link
Member Author

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @panteliselef - the snapshot version command generated the following package versions:

Package Version
@clerk/backend 0.36.0-snapshot.v3d9144d
@clerk/chrome-extension 0.6.0-snapshot.v3d9144d
@clerk/clerk-js 4.67.0-snapshot.v3d9144d
@clerk/clerk-expo 0.19.25-snapshot.v3d9144d
@clerk/fastify 0.6.27-snapshot.v3d9144d
gatsby-plugin-clerk 4.4.29-snapshot.v3d9144d
@clerk/localizations 1.26.13-snapshot.v3d9144d
@clerk/nextjs 4.28.0-snapshot.v3d9144d
@clerk/clerk-react 4.30.0-snapshot.v3d9144d
@clerk/remix 3.1.11-snapshot.v3d9144d
@clerk/clerk-sdk-node 4.13.2-snapshot.v3d9144d
@clerk/types 3.60.0-snapshot.v3d9144d

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend

npm i @clerk/backend@0.36.0-snapshot.v3d9144d --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@0.6.0-snapshot.v3d9144d --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@4.67.0-snapshot.v3d9144d --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@0.19.25-snapshot.v3d9144d --save-exact

@clerk/fastify

npm i @clerk/fastify@0.6.27-snapshot.v3d9144d --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@4.4.29-snapshot.v3d9144d --save-exact

@clerk/localizations

npm i @clerk/localizations@1.26.13-snapshot.v3d9144d --save-exact

@clerk/nextjs

npm i @clerk/nextjs@4.28.0-snapshot.v3d9144d --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@4.30.0-snapshot.v3d9144d --save-exact

@clerk/remix

npm i @clerk/remix@3.1.11-snapshot.v3d9144d --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@4.13.2-snapshot.v3d9144d --save-exact

@clerk/types

npm i @clerk/types@3.60.0-snapshot.v3d9144d --save-exact

@panteliselef panteliselef added this pull request to the merge queue Dec 13, 2023
Merged via the queue into release/v4 with commit 96b9bb5 Dec 13, 2023
7 checks passed
@panteliselef panteliselef deleted the elef/backport-core-1219 branch December 13, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants