Add js to scroll nav so that the link to the current page is shown #60
+22
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 4, 2019 13:09
Matching on 'starts with' can result in multiple matches expanding inappropriately.
toddq
commented
Apr 4, 2019
| @@ -1,16 +1,14 @@ | |||
| function hideAllButCurrent(){ | |||
| //by default all submenut items are hidden | |||
There was a problem hiding this comment.
Like the comment says, they're already hidden by the template, so there's no reason to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the nav menu is long and you click a link towards the bottom, it's annoying that it scrolls back to the top on page load and the clicked link is no longer visible on the page. This simply scrolls the nav link for the page currently being viewed is visible on page load.
It also contains a fix for the nav collapse script only matching on 'starts with', which in our project resulted in several items sometimes being opened. For example we have a 'Session' class and a 'SessionManager' class, so 'starts with' Session matches both. New logic matches exact name. Let me know if this should be split out to a separate pull request.