Commits on Dec 28, 2023

1. perf: Avoid retrieving possible_values unless used …

   In some sophisticated situations, these may be expensive to calculate.
   One example might be a '--branch' option accepting any single Git
   branch that exists on the remote -- in such a case, the remote would
   need to be queried for all possible_values. The cost is ultimately
   unavoidable at runtime since this validation has to happen eventually,
   but there's no need to pay it when generating help text if
   `is_hide_possible_values_set`.
   
   To keep '-h' fast, avoid collecting `possible_values` during '-h'
   unless we're actually going to use the values in display.
   
   This optimization is repeated for the manpage renderer.
   
   This is trivially based on the short-circuiting logic at [1], which at
   least supports the idea that actually consuming the iterator is not
   generally-guaranteed behavior when `hide_possible_values` is set.
   
   Note on the 'expensive' mod: This keeps all the possible_values tests
   in one file but allows the entire set of tests to be controlled by the
   'strings' feature (which is required to be able to use String rather
   than str for each possible value).
   
   [1]: clap_builder/src/builder/command.rs:long_help_exists_

   

   vermiculus committed Dec 28, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 05cd057
   • Browse repository at this point

   Copy the full SHA

   05cd057 View commit details

   Browse the repository at this point in the history