fix: (fish-completion) correct value enum help text

[jporwal05]

Resolves #5101

• The completion of value enums now displays accurate help text
• This fix encloses help text in single quotes
• Comma in help text is not escaped
• This is because the the help text is now treated as literal
• No variable expansion or command substitution in help text

[epage]

We've recently added support for end-to-end testing of completions.

Instead of this test could you

1. Move the choice arg to examples/exhaustive.rs under the quote subcommand?
2. Can you add additional asserts to fn complete at the end of the file to do end-to-end verification of this behavior?

I would ask all of this be done in one commit and do whatever it takes to make it pass (even if it shows bad output) and then put the fix commit on top of it. That will help show to both you and me that the test is testing the correct situation and that the behavior is fixed.

[jporwal05]

So, in summary, we need a failing commit first and then a fix for it. Effectively, there would only be two commits. Please confirm my understanding @epage. I will make the suggested changes.

[epage]

To be explicit, it should be a failing commit in that it shows the via passing tests rather than tests failing.

[epage]

Besides that, yes

[jporwal05]

Understood @epage. Will raise a new PR and link here.

[jporwal05]

Opened #5114
It incorporates the changes suggested here.