Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(derive): Don't warn when people bring types into scope #4952

Merged
merged 3 commits into from
Jun 5, 2023
Merged

fix(derive): Don't warn when people bring types into scope #4952

merged 3 commits into from
Jun 5, 2023

Commits on Jun 5, 2023

  1. fix(derive): Mark all impls as automatically derived 

    Unsure what all it does.  I removed our `allow`s and we still get lints,
so unsure if its only some that it applies to it.

Inspired by clap-rs#4951
    @epage
    epage committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    e7729d1 View commit details
    Browse the repository at this point in the history

  2. style: Remove unused mut

    @epage
    epage committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    5661b6b View commit details
    Browse the repository at this point in the history

  3. fix(derive): Don't warn when people bring types into scope 

    Fixes clap-rs#4951
    @epage
    epage committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    103ae5c View commit details
    Browse the repository at this point in the history