-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Snapshots Collection #53
base: develop
Are you sure you want to change the base?
Conversation
Add the snapshots collection and its query to the array of collections to extract
move snapshots below requests in collections list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, though I have questions about what exactly this means, but I will talk with @climber-girl about them:
We need to pull the snapshots data so the Crossfeed application can recreate the VS report for stakeholders.
Do you only want snapshot data going forward (i.e. after this PR is merged and deployed) or do you also want the ~1.2 million snapshot documents that already exist in the CyHy DB? If the latter, then we will have to coordinate on that outside of this PR.
We only want snapshots going forward. |
Excellent, thanks for confirming! π |
@dav3r I am not authorized to merge, is there anything else that is required before this can be merged? |
I think all that's left is for you to check any remaining checkboxes in the PR description that apply (e.g. the one about reading the CONTRIBUTING doc), then remove any checkboxes or sections (e.g. the Pre-merge checklist) that don't apply. Note that I put a couple of post-merge tasks in, one for your team and one for my team. |
@dav3r All checks complete, and we have reached out to AE so they are aware a new collection is on the way |
Is the "All future TODOs are captured in issues, which are referenced in code comments." checkbox needed here or can that just be deleted? I didn't see any TODOs in this PR. |
@DJensen94 I just got an email from @jessiebeals stating:
We are going to hold off on merging this PR until I get the green light from the AE side, mainly to ensure that this code is not unintentionally deployed before they are ready. I'm adding the |
Add the snapshots collection and its query to the array of collections to extract
π£ Description
Add the snapshots collection and its query to the array of collections to extract.
π Motivation and context
We need to pull the snapshots data so the Crossfeed application can recreate the VS report for stakeholders.
π§ͺ Testing
Tested query locally
β Pre-approval checklist
in code comments.
β Pre-merge checklist
β Post-merge checklist