Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/linux: use unix.Auxv #1665

Merged
merged 1 commit into from
Feb 4, 2025
Merged

internal/linux: use unix.Auxv #1665

merged 1 commit into from
Feb 4, 2025

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Feb 4, 2025

Use the newly added Auxv wrapper added in golang.org/x/sys/unix v0.30.0 instead of manually go:linknaming runtime.getAuxv. This also allows to get rid of the check for malformed auxv data as it is already performed by unix.Auxv.

@tklauser tklauser requested a review from a team as a code owner February 4, 2025 14:30
@tklauser tklauser force-pushed the unix-auxv branch 2 times, most recently from 29a58e4 to a29fcdc Compare February 4, 2025 14:35
@tklauser tklauser closed this Feb 4, 2025
@tklauser
Copy link
Member Author

tklauser commented Feb 4, 2025

Sorry, opened this a bit too quickly. Will reopen once this is ready.

@tklauser tklauser reopened this Feb 4, 2025
@tklauser tklauser marked this pull request as draft February 4, 2025 14:42
Use the newly added Auxv wrapper added in golang.org/x/sys/unix v0.30.0
instead of manually go:linknaming runtime.getAuxv. This also allows to
get rid of the check for malformed auxv data as it is already performed
by unix.Auxv.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser marked this pull request as ready for review February 4, 2025 14:54
Copy link
Collaborator

@ti-mo ti-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you! [][2]uintptr also makes a lot more sense, indeed. :)

@ti-mo ti-mo merged commit 8462e8f into cilium:main Feb 4, 2025
18 checks passed
@tklauser tklauser deleted the unix-auxv branch February 4, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants