Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change DateTime::timestamp_nanos() to return Option #613

Closed
wants to merge 4 commits into from
Closed

Change DateTime::timestamp_nanos() to return Option #613

wants to merge 4 commits into from

Conversation

Milo123459
Copy link
Member

@Milo123459 Milo123459 commented Oct 29, 2021 •
edited

Thanks for contributing to chrono!

  • Have you added yourself and the change to the changelog? (Don't worry
    about adding the PR number)
  • If this pull request fixes a bug, does it add a test that verifies that
    we can't reintroduce it?

Fixes #586

@Milo123459 Milo123459 mentioned this pull request Oct 29, 2021
Closed
@Milo123459
Copy link
Member Author

It's failing due to an unrelated change. After looking into it, it is something broken with bincode.

@Milo123459
Copy link
Member Author

This is breaking because of MSRV. Once #578 gets merged, this can be merged safely.

@andy128k
Copy link

Why not i128?

@esheppa esheppa added this to the 0.5 milestone Jun 17, 2022
@esheppa esheppa added the API-incompatible Tracking changes that need incompatible API revisions label Jun 18, 2022
@esheppa esheppa mentioned this pull request Jul 3, 2022
Closed
@djc djc changed the title fix 586 Change DateTime::timestamp_nanos() to return Option Jul 4, 2022
@Milo123459 Milo123459 closed this Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickelc nickelc nickelc left review comments

Assignees
No one assigned
Labels
API-incompatible Tracking changes that need incompatible API revisions
Projects
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.

DateTime.timestamp_nanos() on valid DateTime panics instead of returning a result/option
4 participants
@Milo123459 @andy128k @nickelc @esheppa