Check short/long weekday/month by char instead of byte #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An alternative to this PR was merged in #1024. |
|
@UnicodingUnicorn you're welcome to add the two test assertions which I would Approve. But otherwise, according to @pitdicker this can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to chrono!
about adding the PR number)
we can't reintroduce it?
When looking at Issue #531, I saw that for some reason when parsing short/long months/weekdays, chrono checks the string byte by byte instead of char by char, which gives up the ghost when Unicode gets involved. I don't know if it is some weird optimisation thing I don't get, but I changed it to check by char instead.