Fix possible panic in NaiveDate::from_num_days_from_ce_opt #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! If you rebase on main the clippy lints should go away. Just curious, did you actually run into this issue or did you just notice it? |
Add some test including panic triggering example `NaiveDate::from_num_days_from_ce_opt(i32::MAX)`. As the function already yields `None` for `i32::Max - 365`, this fix does not change the behaviour, while preventing a panic.
quodlibetor
force-pushed
the
fix_overflow
branch
from
74272dd
to
b7d0213
Compare
|
Actually I was able to rebase for you. |
|
Thanks for rebasing. |
jtmoon79
suggested changes
Apr 26, 2023
| #[test] | ||
| fn test_date_from_num_days_from_ce_opt() { | ||
| let ndays_from_ce = |days| NaiveDate::from_num_days_from_ce_opt(days); | ||
| ndays_from_ce(i32::MAX); |
There was a problem hiding this comment.
Can these two checks be moved into test_date_from_num_days_from_ce below?
Also, why not check the return value of the closure ?
|
This was taken care of in #1052. Thanks for doing the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some test including panic triggering example
NaiveDate::from_num_days_from_ce_opt(i32::MAX).As the function already yields
Nonefori32::Max - 365, this fixdoes not change the behaviour, while preventing a panic.
Thanks for contributing to chrono!
about adding the PR number)
we can't reintroduce it?