Fixed typo in Duration::hours() exception #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.4.x #1384 +/- ##
==========================================
+ Coverage 91.69% 91.72% +0.03%
==========================================
Files 38 38
Lines 17608 17268 -340
==========================================
- Hits 16145 15839 -306
+ Misses 1463 1429 -34 ☔ View full report in Codecov by Sentry. |
pitdicker
approved these changes
Jan 25, 2024
jtmoon79
approved these changes
Jan 25, 2024
montekki
pushed a commit
to matter-labs/zksync-withdrawal-finalizer
that referenced
this pull request
Jan 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [chrono](https://togithub.com/chronotope/chrono) | workspace.dependencies | patch | `0.4.32` -> `0.4.33` | --- ### Release Notes <details> <summary>chronotope/chrono (chrono)</summary> ### [`v0.4.33`](https://togithub.com/chronotope/chrono/releases/tag/v0.4.33): 0.4.33 [Compare Source](https://togithub.com/chronotope/chrono/compare/v0.4.32...v0.4.33) #### What's Changed - Fixed typo in Duration::hours() exception by [@​danwilliams](https://togithub.com/danwilliams) in [chronotope/chrono#1384 - Make `rkyv` feature imply `size_32` by [@​pitdicker](https://togithub.com/pitdicker) in [chronotope/chrono#1383 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/matter-labs/zksync-withdrawal-finalizer). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
to smartive/zitadel-rust
that referenced
this pull request
Jan 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [chrono](https://togithub.com/chronotope/chrono) | dev-dependencies | patch | `0.4.32` -> `0.4.33` | --- ### Release Notes <details> <summary>chronotope/chrono (chrono)</summary> ### [`v0.4.33`](https://togithub.com/chronotope/chrono/releases/tag/v0.4.33): 0.4.33 [Compare Source](https://togithub.com/chronotope/chrono/compare/v0.4.32...v0.4.33) #### What's Changed - Fixed typo in Duration::hours() exception by [@​danwilliams](https://togithub.com/danwilliams) in [chronotope/chrono#1384 - Make `rkyv` feature imply `size_32` by [@​pitdicker](https://togithub.com/pitdicker) in [chronotope/chrono#1383 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm,before 6am" in timezone Europe/Zurich, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/smartive/zitadel-rust). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
danwilliams
added a commit
to danwilliams/rubedo
that referenced
this pull request
Jan 28, 2024
](https://renovatebot.com){kind=link}
The typo in Chrono was fixed in version 0.4.33, as a result of PR chronotope/chrono#1384, and so the related tests have been updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR simply fixes a typo found in the exception message thrown from
Duration::hours()when the value is out of range.Points of note
Tests
There are no current tests that use the exception message, and so none have been updated. All tests pass.
Branch point
The branch point chosen has been the latest tagged release, with the PR targeting the
0.4.xbranch.