Revert changes to TimeZoneName::new parser #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could this PR include another commit to add the |
djc
approved these changes
Jul 4, 2023
|
Oops, should have noticed this in review. |
I think having a test that mostly is a list of numbers or offset values works a bit confusing. But I've updated the test to some realistic values, and to test the cases |
pitdicker
force-pushed
the
tzfile_tzname
branch
2 times, most recently
from
5890e6d
to
fe37696
Compare
|
Sorry for all the pushes. This is not working from a Windows PC 😆 |
|
@jtmoon79 Are the changes to the test acceptable? |
|
@djc do you want to have a second look at the test, or shall I merge this? |
|
Thanks for asking, merge away! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1087 (comment).
With the changes to support a minus sign when parsing a timezone offset, #1087 accidentally changed the parsing of a timezone abbreviation in a tzif file. This is just a short ASCII string, that doesn't care about a minus sign.