Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test GitHub workflow #1279

Merged
merged 1 commit into from Mar 17, 2023
Merged

Improve test GitHub workflow #1279

merged 1 commit into from Mar 17, 2023

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Mar 11, 2023

This PR extends the GitHub workflow by running tests on Go 1.16.x and the 2 supported major go releases. This ensures that chromedp doesn't break compatibility with older Go versions, like in #1277.

Additionally:

  • update actions/setup-go to v4
  • update actions/checkout to v3;
  • split Testrun to Test Chrome and Test headless-shell.

@alexandear alexandear marked this pull request as ready for review March 11, 2023 13:54
@alexandear alexandear changed the title Add Go 1.16 and 1.20 to GitHub workflow Improve test GitHub workflow Mar 11, 2023
Copy link
Member

@ZekeLu ZekeLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you!

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
Add Go 1.16 to ensure compatibility with older Go versions (see #1277).
@alexandear alexandear requested a review from ZekeLu March 16, 2023 16:29
@ZekeLu ZekeLu merged commit d7670e7 into chromedp:master Mar 17, 2023
3 checks passed
@alexandear alexandear deleted the extend-workflow-with-other-go branch March 17, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants