-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Use figment configuration for chroma-load #3203
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
} | ||
|
||
#[derive(Deserialize)] | ||
pub struct LoadServiceConfig { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be a silly question, but is it common for the type to indicate what it's doing (aka a verb) versus being just a noun? Speicifically, what I'm wondering if ServiceConfig
is appropriate here vs LoadServiceConfig
? Just curious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Load Service" is a proper noun in this context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
This mirrors the compactor and query services (and can even merge with their configs if we so choose).
This mirrors the compactor and query services (and can even merge with
their configs if we so choose).