Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Use figment configuration for chroma-load #3203

Merged
merged 5 commits into from
Dec 3, 2024
Merged

[ENH] Use figment configuration for chroma-load #3203

merged 5 commits into from
Dec 3, 2024

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Nov 26, 2024

This mirrors the compactor and query services (and can even merge with
their configs if we so choose).

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Sorry, something went wrong.

}

#[derive(Deserialize)]
pub struct LoadServiceConfig {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be a silly question, but is it common for the type to indicate what it's doing (aka a verb) versus being just a noun? Speicifically, what I'm wondering if ServiceConfig is appropriate here vs LoadServiceConfig? Just curious.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Load Service" is a proper noun in this context.

Copy link
Contributor

@Sicheng-Pan Sicheng-Pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

This mirrors the compactor and query services (and can even merge with
their configs if we so choose).
Base automatically changed from rescrv/load2 to main December 3, 2024 00:54
@rescrv rescrv merged commit 2ac6b3e into main Dec 3, 2024
71 checks passed
@rescrv rescrv deleted the rescrv/load3 branch December 3, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants