Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] add log id to pullLogs response #1809

Merged
merged 2 commits into from
Mar 4, 2024
Merged

[ENH] add log id to pullLogs response #1809

merged 2 commits into from
Mar 4, 2024

Conversation

weiligu
Copy link
Contributor

@weiligu weiligu commented Mar 4, 2024 •
edited

Description of changes

add log id to pullLogs respons

Test plan

  • log_service_test

@weiligu Graphite App
Copy link
Contributor Author

weiligu commented Mar 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @weiligu and the rest of your teammates on Graphite Graphite

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@weiligu weiligu requested a review from Ishiihara March 4, 2024 19:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@weiligu weiligu added the enhancement New feature or request label Mar 4, 2024
@weiligu weiligu changed the title add log id to pullLogs response [ENH] add log id to pullLogs response Mar 4, 2024
@weiligu weiligu marked this pull request as ready for review March 4, 2024 19:25
Ishiihara
Ishiihara approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@Ishiihara Ishiihara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weiligu weiligu enabled auto-merge (squash) March 4, 2024 21:49
@weiligu weiligu merged commit 8bb8055 into main Mar 4, 2024
120 checks passed
atroyn pushed a commit to csbasil/chroma that referenced this pull request Apr 3, 2024
@weiligu @atroyn
[ENH] add log id to pullLogs response (chroma-core#1809)
62dd330 
## Description of changes
add log id to pullLogs respons

## Test plan
- [ ] log_service_test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ishiihara Ishiihara Ishiihara approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@weiligu @Ishiihara