[ENH] get collection info for compactor #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
|
Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas |
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
weiligu
commented
Feb 27, 2024
Comment on lines
-3
to
-4
| // protoc-gen-go v1.26.0 | ||
| // protoc v4.24.4 |
Ishiihara
approved these changes
Feb 27, 2024
| log.Error("error getting collection info", zap.Error(err)) | ||
| return nil, grpcutils.BuildInternalGrpcError("error getting collection info") | ||
| } | ||
| for index := range recordLogs { |
There was a problem hiding this comment.
for _, recordLog := range recordLogs {
}
| select r.collection_id, r.id, r.timestamp, row_number() over(partition by r.collection_id order by r.id) as rank | ||
| from record_logs r, collections c | ||
| where r.collection_id = c.id | ||
| and r.id>c.log_position |
There was a problem hiding this comment.
Will compactor update the log position?
There was a problem hiding this comment.
yes go API is tracked here https://linear.app/trychroma/issue/CHR-298/segment-compaction-flush
log position needs to be updated in the same transaction that also registers S3 files.
weiligu
force-pushed
the
02-23-get_collection_ids_to_compact
branch
from
5d417b4
to
516b33b
Compare
atroyn
pushed a commit
to csbasil/chroma
that referenced
this pull request
Apr 3, 2024
## Description of changes https://linear.app/trychroma/issue/CHR-293/get-collection-ids-for-compactor - get collection information for collections that need to be compacted, order by timestamps of the log - DB retry is not included ## Test plan - [ ] record_log_test and record_log_service_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
https://linear.app/trychroma/issue/CHR-293/get-collection-ids-for-compactor
Test plan
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?