feature(cache): dynamodb implementation #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
…rface (project-zot#667) Moved boltdb to a driver implementation for such interface Added CreateCacheDatabaseDriver in controller Fixed default directory creation (boltDB will only create the file, not the dir Added coverage tests Added example config for boltdb Re-added caching on subpaths, rewrote CreateCacheDatabaseDriver Fix tests Made cacheDriver argument mandatory for NewImageStore, added more validation, added defaults Moved cache interface to own file, removed useRelPaths from config Got rid of cache config, refactored Moved cache to own package and folder Renamed + removed cache factory to backend, replaced CloudCache to RemoteCache Moved storage constants back to storage package moved cache interface and factory to storage package, changed remoteCache defaulting Signed-off-by: Catalin Hofnar <catalin.hofnar@gmail.com>
Signed-off-by: Catalin Hofnar <catalin.hofnar@gmail.com>
chofnar
force-pushed
the
dynamodbReimplementation
branch
from
56e7f57
to
e360e37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
enhancement
Which issue does this PR fix:
Part of project-zot#564
What does this PR do / Why do we need it:
Added AWS DynamoDB driver.
Will this break upgrades or downgrades?
If a client uses DynamoDB and decides to downgrade, they must make sure that the database is migrated to BoltDB to avoid data loss.
New validations that might break stuff:
local storage driver, but explicit RemoteCache=true, this is not valid, so error ou
remote storage driver, but no "cacheDriver" config section, error out
Defaults:
local storage driver -> RemoteCache=false
remote storage driver (s3) -> RemoteCache=true
Does this PR introduce any user-facing change?:
Adds the possibility to use AWS DynamoDB instead of BoltDB
Problems
To do
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.