DynamoDB integration #18
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Catalin Hofnar <catalin.hofnar@gmail.com>
Added proper endpoint handling, logging, tests Implemented more functions, added more tests, updated errors Added aws databases documentation Added DB driver and factories, need to implement Implemented Factory and Driver interfaces for dynamodb Refactor cache.go and changed some stuff Rewrote some stuff, TODO: fix PutBlob Fixed dynamoDB functions Refactor boltDB to use new interface Fixed gotcha Lint Point S3 to use DynamoDB database instead of boltdb Reverted s3 use only boltdb Added more dynamodb tests, fixed errors lint Added database factory tests, removed Scan and DescribeTable functions Added loading of db parameters from either config or env Renamed packages and moved files around to avoid cyclic import Added more coverage tests Removed env var usage for config Added benchmark tests Signed-off-by: Catalin Hofnar <catalin.hofnar@gmail.com>
Signed-off-by: Catalin Hofnar <catalin.hofnar@gmail.com>
Signed-off-by: Catalin Hofnar <catalin.hofnar@gmail.com>
Signed-off-by: Catalin Hofnar <catalin.hofnar@gmail.com>
This was referenced Jul 21, 2022
chofnar
force-pushed
the
cachedbInterface
branch
3 times, most recently
from
f40cc05
to
78272b9
Compare
Signed-off-by: Catalin Hofnar <catalin.hofnar@gmail.com>
chofnar
force-pushed
the
cachedbInterface
branch
11 times, most recently
from
699a9ef
to
60d3d2b
Compare
chofnar
force-pushed
the
cachedbInterface
branch
4 times, most recently
from
a5ab8ec
to
44e6374
Compare
chofnar
force-pushed
the
cachedbInterface
branch
12 times, most recently
from
25d70ce
to
1f5d536
Compare
chofnar
force-pushed
the
cachedbInterface
branch
9 times, most recently
from
fc8b2d0
to
bfa7174
Compare
chofnar
force-pushed
the
cachedbInterface
branch
3 times, most recently
from
31df3c8
to
9df5c07
Compare
chofnar
force-pushed
the
cachedbInterface
branch
6 times, most recently
from
f1cc6c1
to
7ad8818
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
enhancement
Which issue does this PR fix:
Part of project-zot#564
What does this PR do / Why do we need it:
Added AWS DynamoDB driver.
Will this break upgrades or downgrades?
If a client uses DynamoDB and decides to downgrade, they must make sure that the database is migrated to BoltDB to avoid data loss.
Does this PR introduce any user-facing change?:
Adds the possibility to use AWS DynamoDB instead of BoltDB
Problems
Other comments
Inspiration from https://github.com/distribution/distribution
To do
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.