Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on <literal>.asUInt|.asSInt(_: Int) (backport #4764) #4766

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

chiselbot
Copy link
Collaborator

Fixes #4733

Unfortunately, this is really hard to write a unit test for, but I did manually check it works (and it's using the same approach as we have been using for .U and .S). I'm also not sure that this is the best fix for 4733, but it works.

FYI @tymcauley

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • API deprecation

Desired Merge Strategy

  • Squash

Release Notes

The user probably forgot .W. Apply the same technique as used for .U|.S.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

This is an automatic backport of pull request #4764 done by [Mergify](https://mergify.com).

Sorry, something went wrong.

The user probably forgot .W. Apply the same technique as used for .U|.S.

(cherry picked from commit 811bb46)
@mergify mergify bot added the Backport Automated backport, please consider for minor release label Mar 4, 2025
@mergify mergify bot mentioned this pull request Mar 4, 2025
14 tasks
@github-actions github-actions bot added the Deprecation Deprecates an API, will be included in release notes label Mar 4, 2025
@chiselbot chiselbot merged commit c2a612f into 6.x Mar 4, 2025
17 checks passed
@chiselbot chiselbot deleted the mergify/bp/6.x/pr-4764 branch March 4, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Automated backport, please consider for minor release Deprecation Deprecates an API, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants