Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup Computation for whether Aggregates containsProbe (backport #4656) #4664

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

chiselbot
Copy link
Collaborator

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • [N/A] Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Performance improvement

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Add a private containsProbe var to Aggregate and use it to speed up containsProbe checks.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

This is an automatic backport of pull request #4656 done by [Mergify](https://mergify.com).

Sorry, something went wrong.

* save the elementContainsProbes for an Aggregate to speed up various computations
* add unit tests for ContainsProbe

(cherry picked from commit c9cecfa)
@mergify mergify bot added the Backport Automated backport, please consider for minor release label Feb 4, 2025
@github-actions github-actions bot added the Performance Improves performance, will be included in release notes label Feb 4, 2025
@chiselbot chiselbot merged commit 6b7429a into 6.x Feb 4, 2025
17 checks passed
@chiselbot chiselbot deleted the mergify/bp/6.x/pr-4656 branch February 4, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Automated backport, please consider for minor release Performance Improves performance, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants