fix recent failures in publish-website.yml #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub's API is now redirecting requests to download GHA artifacts to https://productionresultssa0.blob.core.windows.net/. This service rejects requests that contain an Authorization header, breaking our publish-website.yml workflow. octocrab should not be sending this header when redirected, and I have filed XAMPPRocky/octocrab#562 to address the bug. Until that PR is merged, we can work around this issue by enabling octocrab's "follow-redirect" feature, which configures the tower middleware to handle the redirect instead of octocrab, which (correctly) doesn't include the authentication header in the redirected requests.
korran
changed the title
This works around a failure that started occuring after a new version of target-spec was released over the weekend: ``` error: package `target-spec v3.1.0` cannot be built because it requires rustc 1.73 or newer, while the currently active rustc version is 1.70.0 ```
jhand2
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These failures are preventing the release workflow from fully completing (regenerating the text matrix).
Recent failure of build step:
https://github.com/chipsalliance/caliptra-sw/actions/runs/7790925130/job/21246025351
With these fixes (build step succeeds; deploy failure is expected because this branch doesn't have publish permission):
https://github.com/chipsalliance/caliptra-sw/actions/runs/7791090616/job/21246392938
test-matrix: Fix failure with artifact redirects.
GitHub's API is now redirecting requests to download GHA artifacts to https://productionresultssa0.blob.core.windows.net/. This service rejects requests that contain an Authorization header, breaking our publish-website.yml workflow. octocrab should not be sending this header when redirected, and I have filed
XAMPPRocky/octocrab#562 to address the bug.
Until that PR is merged, we can work around this issue by enabling octocrab's "follow-redirect" feature, which configures the tower middleware to handle the redirect instead of octocrab, which (correctly) doesn't include the authentication header in the redirected requests.
test-matrix: Include Cargo.lock
This works around this failure: