Upgrade standard to 1.34 #1346
Closed
Upgrade standard to 1.34 #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [standard](https://github.com/standardrb/standard) from 1.33.0 to 1.34.0. - [Release notes](https://github.com/standardrb/standard/releases) - [Changelog](https://github.com/standardrb/standard/blob/main/CHANGELOG.md) - [Commits](standardrb/standard@v1.33.0...v1.34.0) --- updated-dependencies: - dependency-name: standard dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
+1 to hold off on this one - i think we can tell dependabot to skip a version |
|
Ignored in #1341 and we can let the next update swing around 馃憤馃徎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Upgrades standard and fixes a few issues from a new default setting. It promotes the use of anonymous block arguments forwarding, which... 馃し馃徎
Standard only found some of the uses of
&blockin the codebase, which isn't great. It looks like there are some issues with the changes in Ruby 3.3 that may be trickling down here based on Naming/BlockForwarding with anonymous block parameter (Ruby 3.3.0)We might want to wait on this one to let some of these issues get shaken out.