Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ§ͺ Pin latest to macos-13 @ CI #697

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

webknjaz
Copy link
Member

@webknjaz webknjaz commented Apr 24, 2024

macos-latest now corresponds to macos-14-arm64 which is not yet compatible with the lock files we got.

❓ What kind of change does this PR introduce?

  • 🐞 bug fix
  • 🐣 feature
  • πŸ“‹ docs update
  • πŸ“‹ tests/coverage improvement
  • πŸ“‹ refactoring
  • πŸ’₯ other

πŸ“‹ What is the related issue number (starting with #)

N/A

❓ What is the current behavior? (You can also link to an open issue here)

The macos-latest jobs fail in CI.

❓ What is the new behavior (if this is a feature change)?

They shouldn't.

πŸ“‹ Other information:

macos-latest switched to macos-14-arm64 suddenly (it was macos-12 a day ago).

Refs:

πŸ“‹ Contribution checklist:

(If you're a first-timer, check out
this guide on making great pull requests)

  • I wrote descriptive pull request text above
  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after
    the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

This change is Reviewable

`macos-latest` now corresponds to `macos-14-arm64` which is not yet
compatible with the lock files we got.
@webknjaz webknjaz self-assigned this Apr 24, 2024
@webknjaz webknjaz merged commit 1e05bcc into cherrypy:main Apr 24, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant