Issue #13213: Remove "//ok" from input files #14616
Conversation
* Issue checkstyle#13213: Removed '//ok' from operatorwrap * Issue checkstyle#13345: EnabledAtClauseOrderCheckExampleTest * Issue checkstyle#13213: remove"//ok"from InputJavadocMethod2 * Issue checkstyle#13213: Remove"//ok"from InputJavadocMethod1 * Issue checkstyle#13213: Remove"//ok"from InputJavadocMethod3 * Issue checkstyle#13213: for checkstyle-input-suppression.xml * Issue checkstyle#13213: remove"//ok"from InputJavadocMethod3 * Issue checkstyle#13213: remove"//ok"from InputJavadocMethod2 * Issue checkstyle#13213: Remove"//ok"from InputJavadocMethod1 * Issue checkstyle#13213: remove"//ok"from InputJavadocMethod3 --------- Co-authored-by: 555vedant <vedantvvk5@gmail.com> Co-authored-by: MANISH-K-07 <manish07070707@gmail.com>
There was a problem hiding this comment.
@Pakhi-7831 ,
15.018s ?? What command did you use to build?
Regarding the CI failure, please fix commit message to make CI green
|
It is giving the "Line should not be longer than 100 symbols [lineLength]" error on build now and I am unable to figure the reason or way to rectify it. Can you please provide some guidance so that i may correct it |
There was a problem hiding this comment.
It is giving the "Line should not be longer than 100 symbols [lineLength]" error on build now and I am unable to figure the reason or way to rectify it. Can you please provide some guidance so that i may correct it
I only see improper commit error : https://dev.azure.com/romanivanovjr/romanivanovjr/_build/results?buildId=20302&view=logs&j=c902ebb4-c9f8-5f09-4e17-ff78fbbc842e&t=9ca98c81-ff64-58f0-9d03-a23ac1c4a111&l=1327
I don't see where there is a linelength violation for the changes you have made
Could you provide the error log here?
You can try, the stacktrace shows you the filename and the line number of the violation, you can modify accordingly
|
unable to understand how to fix the error shown on https://dev.azure.com/romanivanovjr/romanivanovjr/_build/results?buildId=20302&view=logs&j=c902ebb4-c9f8-5f09-4e17-ff78fbbc842e&t=9ca98c81-ff64-58f0-9d03-a23ac1c4a111&l=1327 |
There was a problem hiding this comment.
the current commit messages that I can see don't have "*" at the end of the message
Omg how did I miss this !!
You must have made a mistake during rebase.. this commit msg is a combination of many previous merged commit msgs and hence the error. Please go through again on how to rebase and squash, there are many resources online like google
|
@Pakhi-7831, please fix CI failure. |
Removed "//ok" from InputJavadocMethod_01.java, InputJavadocMethod_02.java, InputJavadocMethod_03.java and unwanted okcommitsuppresions from checkstyle-input-suppressions.xml