Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #14014: Ignore left curly in line wrapping indentation handler #14024

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

jungm
Copy link
Contributor

@jungm jungm commented Nov 12, 2023

@romani
Copy link
Member

romani commented Nov 12, 2023

Good.
Please trigger automatic regression by GitHub action
Please read https://github.com/checkstyle/contribution/tree/master/checkstyle-tester#executing-generation

Example on how we do this: #13424 but you need config with indentation check only. There are more examples in PRs.

@jungm
Copy link
Contributor Author

jungm commented Nov 12, 2023

GitHub, generate report

Copy link
Member

@nrmancuso nrmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do:

  1. Generate another regression report using the module at https://checkstyle.sourceforge.io/checks/misc/indentation.html#Example3-config
  2. Create new test/test input using exact configuration and code from issue report, also showing violations on under-indented {

@jungm
Copy link
Contributor Author

jungm commented Nov 13, 2023

GitHub, generate report

Copy link
Contributor

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

Copy link
Member

@nrmancuso nrmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot for your contribution!

@nrmancuso nrmancuso assigned rnveach and unassigned nrmancuso Nov 13, 2023
@romani
Copy link
Member

romani commented Nov 13, 2023

@jungm , as we going close to merge, please let me know if you need this fix to be released after merge. We can trigger release.

@rnveach rnveach merged commit 3a23ae0 into checkstyle:master Nov 13, 2023
113 checks passed
@jungm
Copy link
Contributor Author

jungm commented Nov 14, 2023

@romani a release would be awesome!
Not 100% required from my side, but I would obviously prefer it over using a snapshot build

@romani
Copy link
Member

romani commented Nov 14, 2023

@jungm , thanks a lot for fix
https://checkstyle.org/releasenotes.html#Release_10.12.5

do not hesitate to send more PRs with fixes :) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indentation: Switch expression doesn't pass with LeftCurlies on newlines
4 participants