-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #14014: Ignore left curly in line wrapping indentation handler #14024
Conversation
Good. Example on how we do this: #13424 but you need config with indentation check only. There are more examples in PRs. |
GitHub, generate report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do:
- Generate another regression report using the module at https://checkstyle.sourceforge.io/checks/misc/indentation.html#Example3-config
- Create new test/test input using exact configuration and code from issue report, also showing violations on under-indented
{
GitHub, generate report |
forceStrictCondition=true: |
9ee4718
to
a9d01fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks a lot for your contribution!
@jungm , as we going close to merge, please let me know if you need this fix to be released after merge. We can trigger release. |
@romani a release would be awesome! |
@jungm , thanks a lot for fix do not hesitate to send more PRs with fixes :) . |
This fixes #14014
Diff Regression config: https://gist.githubusercontent.com/jungm/22d6a6a07b5505de2abadc3f68f9e418/raw/697705cfa8a06a514d5c163746de8a7c40391923/config.xml
Report label: forceStrictCondition=true