-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #13809: kill mutation for AuditEventDefaultFormatter #13826
Issue #13809: kill mutation for AuditEventDefaultFormatter #13826
Conversation
4c21095
to
1da8d2b
Compare
fbaeca3
to
02690a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
items:
src/main/java/com/puppycrawl/tools/checkstyle/AuditEventDefaultFormatter.java
Outdated
Show resolved
Hide resolved
b24014d
to
0566523
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Items
777aa81
to
cc246f9
Compare
@Kevin222004 , please move forward to other mutation s, I will handle this update to figure out how to avoid mutation. |
cc246f9
to
8adf5ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok to merge.
I did this change :).
8adf5ae
to
b4cbba4
Compare
b4cbba4
to
04c940e
Compare
@romani thanks, I have Fixed the ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Issue #13809: kill mutation for AuditEventDefaultFormatter
Explaintation
I didn't find any test case for this and the reason may be in StringBuilder even after we assign the capacity if the character or string goes beyond the limit of assigned capacity. it will automatically expands the necessary memory to accommodate character to string builder.