Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #13809: kill mutation for AuditEventDefaultFormatter #13826

Merged

Conversation

Kevin222004
Copy link
Contributor

Issue #13809: kill mutation for AuditEventDefaultFormatter

Explaintation

I didn't find any test case for this and the reason may be in StringBuilder even after we assign the capacity if the character or string goes beyond the limit of assigned capacity. it will automatically expands the necessary memory to accommodate character to string builder.

@Kevin222004 Kevin222004 force-pushed the AuditEventDefaultFormatter branch 3 times, most recently from fbaeca3 to 02690a6 Compare October 4, 2023 11:13
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

@romani romani self-assigned this Oct 4, 2023
@Kevin222004 Kevin222004 force-pushed the AuditEventDefaultFormatter branch 2 times, most recently from b24014d to 0566523 Compare October 4, 2023 16:09
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items

pom.xml Outdated Show resolved Hide resolved
@Kevin222004 Kevin222004 force-pushed the AuditEventDefaultFormatter branch 3 times, most recently from 777aa81 to cc246f9 Compare October 5, 2023 09:20
@romani
Copy link
Member

romani commented Oct 5, 2023

@Kevin222004 , please move forward to other mutation s, I will handle this update to figure out how to avoid mutation.

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge.

I did this change :).

@romani romani requested a review from rdiachenko October 7, 2023 15:24
@romani romani assigned rdiachenko and unassigned romani Oct 7, 2023
@Kevin222004
Copy link
Contributor Author

@romani thanks, I have Fixed the ci

Copy link
Contributor

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rdiachenko rdiachenko merged commit 7d53438 into checkstyle:master Oct 7, 2023
112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants