Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #13809: kill mutation for RootNode getColumnNumber #13817

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Issue #13809: kill mutation for RootNode getColumnNumber #13817

merged 1 commit into from
Oct 5, 2023

Conversation

romani
Copy link
Member

@romani romani commented Oct 3, 2023

Issue #13809

@romani
Copy link
Member Author

romani commented Oct 3, 2023

@rnveach , do you remmber why lines starts with 1 but columns from 0 ?
Looks weird.

@rnveach
Copy link
Member

rnveach commented Oct 3, 2023

#4997
#5877

@Kevin222004 Kevin222004 mentioned this pull request Oct 3, 2023
Closed
33 tasks
@romani romani force-pushed the i13809-root-col branch 2 times, most recently from 815c4ef to e530bbd Compare October 4, 2023 12:49
@romani
Copy link
Member Author

romani commented Oct 4, 2023

@rnveach , I put link to issue as "until" for this pure unit test.

@romani romani requested a review from Vyom-Yadav October 4, 2023 12:57
@romani romani requested a review from rdiachenko October 4, 2023 12:57
rdiachenko
rdiachenko approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@romani
Copy link
Member Author

romani commented Oct 5, 2023

Vyom allowed to merge without him until Monday

@romani romani merged commit 81f6431 into checkstyle:master Oct 5, 2023
112 checks passed
@romani romani deleted the i13809-root-col branch October 5, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdiachenko rdiachenko rdiachenko approved these changes

@Vyom-Yadav Vyom-Yadav Awaiting requested review from Vyom-Yadav

Assignees

@Vyom-Yadav Vyom-Yadav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@romani @rnveach @rdiachenko @Vyom-Yadav