Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #13005: LineLength check documentation incorrectly shows how to… #13077

Merged
merged 1 commit into from
May 22, 2023

Conversation

Andromeda227799
Copy link

Fixing Issue #13005 by replacing TreeWalker with Checker

@Andromeda227799
Copy link
Author

Hey @romani could you help me identify why the CI failed?

@romani
Copy link
Member

romani commented May 21, 2023

please all commits in one. each PR should have only one commit.

CI is restarted.

@Andromeda227799 Andromeda227799 force-pushed the shamith/fix branch 2 times, most recently from 98ccf28 to be349ec Compare May 22, 2023 15:05
@Andromeda227799
Copy link
Author

please all commits in one. each PR should have only one commit.

CI is restarted.

I have done that just now, CI is running, hopefully, it passes 🤞

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge if CI is all green

@romani
Copy link
Member

romani commented May 22, 2023

https://dev.azure.com/romanivanovjr/romanivanovjr/_build/results?buildId=14426&view=logs&j=c902ebb4-c9f8-5f09-4e17-ff78fbbc842e&t=9ca98c81-ff64-58f0-9d03-a23ac1c4a111&l=815

Please make sure commit message was done as it was required.

@Andromeda227799
Copy link
Author

Andromeda227799 commented May 22, 2023

https://dev.azure.com/romanivanovjr/romanivanovjr/_build/results?buildId=14426&view=logs&j=c902ebb4-c9f8-5f09-4e17-ff78fbbc842e&t=9ca98c81-ff64-58f0-9d03-a23ac1c4a111&l=815

Please make sure commit message was done as it was required.

Just amended the commit-msg according to the required regex ^Issue #\d+: .*$

@romani romani merged commit 40af44a into checkstyle:master May 22, 2023
108 of 109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants